[Service Bus] Fix integration test failure on master #11122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
chradek,
ramya-rao-a and
richardpark-msft
as code owners
ghost
added
the
HarshaNalluru
changed the title
ramya-rao-a
reviewed
Sep 8, 2020
| @@ -380,10 +380,16 @@ describe("Sender Tests", () => { | |||
| }); | |||
|
|
|||
| describe("ServiceBusMessage validations", function(): void { | |||
| const sbClient = new ServiceBusClient( | |||
| "Endpoint=sb://a;SharedAccessKeyName=b;SharedAccessKey=c;EntityPath=d" | |||
There was a problem hiding this comment.
Wouldn't removing the EntityPath=d" from the connection string have been enough to fix the test?
There was a problem hiding this comment.
Yes, that is enough.
However, since this code was not part of any before section, this gets executed before mocha reports the describe block as being run, which makes it non-trivial to know where the failure is.
Making it part of the before section would help pinpoint this describe block if a failure happens.
ramya-rao-a
approved these changes
Sep 8, 2020
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.