-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OTel exporter API to autoconfigure distro API #42566
Open
jeanbisutti
wants to merge
20
commits into
main
Choose a base branch
from
jean/otel-exporter-otel-autoconfigure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+729
−729
Open
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
549b6b7
Rename folder and artifact
jeanbisutti 56299ee
Update POMs
jeanbisutti 856644a
Update comments
jeanbisutti aeeb21c
Update Docker file
jeanbisutti 2221221
Update CI files
jeanbisutti 2c63258
Change package to com.azure.monitor.opentelemetry.autoconfigure
jeanbisutti f6b3e61
Rename AzureMonitorExporter to AzureMonitorAutoconfigure
jeanbisutti 6d9a30f
Rename AzureMonitorExporterOptions to AzureMonitorAutoconfigureOptions
jeanbisutti 9d22b5d
Update readme examples
jeanbisutti 5e10c43
Update stress tests Java classes with the new API
jeanbisutti 1a75870
Fix Readme
jeanbisutti 157adf3
Try to fix version client issue
jeanbisutti 9b5a5e1
Fix client version
jeanbisutti 443e5bc
Start azure-monitor-opentelemetry-autoconfigure with version beta.1
jeanbisutti d3638b3
Fix client version
jeanbisutti 174b966
AzureMonitorAutoconfigure => AzureMonitorAutoConfigure
jeanbisutti 79be95b
AzureMonitorAutoconfigureOptions => AzureMonitorAutoConfigureOptions
jeanbisutti 1338ce9
Update Readme with new naming
jeanbisutti 796e5d9
AzureMonitorAutoconfigure => AzureMonitorAutoConfigure
jeanbisutti 4aba7eb
Fix Spring compilation issues
jeanbisutti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...onitor-opentelemetry-exporter/assets.json → ...r-opentelemetry-autoconfigure/assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"AssetsRepo": "Azure/azure-sdk-assets", | ||
"AssetsRepoPrefixPath": "java", | ||
"TagPrefix": "java/monitor/azure-monitor-opentelemetry-exporter", | ||
"TagPrefix": "java/monitor/azure-monitor-opentelemetry-autoconfigure", | ||
"Tag": "java/monitor/azure-monitor-opentelemetry-exporter_558a81e425" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Spring CI does not support unreleased non-Spring dependencies. So we temporarily move
azure-monitor-opentelemetry-exporter
as an external dependency (it is no more part of Azure SDK). Onceazure-monitor-opentelemetry-autoconfigure
is released, we could remove the external dependency and theazure-monitor-opentelemetry-exporter
usage inspring-cloud-azure-starter-monitor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saragluna is this true? Spring's hacked together pipeline code doesn't support what the engineering system does? This isn't okay.
@jeanbisutti if this is only a spring dependency only has to exist until com.azure:azure-monitor-opentelemetry-autoconfigure is released then I want an issue filed, assigned to you, to remove this external dependency and update the spring dependency com.azure:azure-monitor-opentelemetry-autoconfigure when it's released.