Move OTel exporter API to autoconfigure distro API #42566
Conversation
jeanbisutti
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova,
JonathanGiles,
alzimmermsft,
a team,
samvaity,
g2vinay,
rujche,
Netyyyy,
saragluna,
moarychan,
mssfang,
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
github-actions
bot
added
azure-spring
| @@ -50,6 +50,7 @@ com.microsoft.sqlserver:mssql-jdbc;10.2.3.jre8 | |||
| com.microsoft.azure:spring-data-cosmosdb;2.3.0 | |||
| com.microsoft.azure:azure-functions-maven-plugin;1.30.0 | |||
| com.microsoft.azure.functions:azure-functions-java-library;2.2.0 | |||
| com.azure:azure-monitor-opentelemetry-exporter;1.0.0-beta.31 | |||
There was a problem hiding this comment.
The Spring CI does not support unreleased non-Spring dependencies. So we temporarily move azure-monitor-opentelemetry-exporter as an external dependency (it is no more part of Azure SDK). Once azure-monitor-opentelemetry-autoconfigure is released, we could remove the external dependency and the azure-monitor-opentelemetry-exporter usage in spring-cloud-azure-starter-monitor.
There was a problem hiding this comment.
@saragluna is this true? Spring's hacked together pipeline code doesn't support what the engineering system does? This isn't okay.
@jeanbisutti if this is only a spring dependency only has to exist until com.azure:azure-monitor-opentelemetry-autoconfigure is released then I want an issue filed, assigned to you, to remove this external dependency and update the spring dependency com.azure:azure-monitor-opentelemetry-autoconfigure when it's released.
|
https://github.com/Azure/azure-sdk-for-java/blob/jean/otel-exporter-otel-autoconfigure/sdk/monitor/azure-monitor-opentelemetry-autoconfigure/assets.json needs to be updated to make the proxy tests work again. |
...e/src/main/java/com/azure/monitor/opentelemetry/autoconfigure/AzureMonitorAutoconfigure.java
Outdated
Show resolved
Hide resolved
| @@ -50,6 +50,7 @@ com.microsoft.sqlserver:mssql-jdbc;10.2.3.jre8 | |||
| com.microsoft.azure:spring-data-cosmosdb;2.3.0 | |||
| com.microsoft.azure:azure-functions-maven-plugin;1.30.0 | |||
| com.microsoft.azure.functions:azure-functions-java-library;2.2.0 | |||
| com.azure:azure-monitor-opentelemetry-exporter;1.0.0-beta.31 | |||
There was a problem hiding this comment.
@saragluna is this true? Spring's hacked together pipeline code doesn't support what the engineering system does? This isn't okay.
@jeanbisutti if this is only a spring dependency only has to exist until com.azure:azure-monitor-opentelemetry-autoconfigure is released then I want an issue filed, assigned to you, to remove this external dependency and update the spring dependency com.azure:azure-monitor-opentelemetry-autoconfigure when it's released.
@JimSuplizio Yes, please assign an issue to me |
@JimSuplizio We have already discussed about this in another place about the |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This PR: