-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update autorest config #28558
Update autorest config #28558
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
// Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
||
package com.azure.communication.chat.implementation.models; | ||
|
||
import com.azure.core.annotation.Fluent; | ||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
/** Request payload for typing notifications. */ | ||
@Fluent | ||
public final class SendTypingNotificationRequest { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have this class as TypingNotificationOptions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This transformation from the Swagger/Readme should've renamed it, if it doesn't anymore something might've changed: directive:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
/* | ||
* The display name of the typing notification sender. This property is | ||
* used to populate sender name for push notifications. | ||
*/ | ||
@JsonProperty(value = "senderDisplayName") | ||
private String senderDisplayName; | ||
|
||
/** | ||
* Get the senderDisplayName property: The display name of the typing notification sender. This property is used to | ||
* populate sender name for push notifications. | ||
* | ||
* @return the senderDisplayName value. | ||
*/ | ||
public String getSenderDisplayName() { | ||
return this.senderDisplayName; | ||
} | ||
|
||
/** | ||
* Set the senderDisplayName property: The display name of the typing notification sender. This property is used to | ||
* populate sender name for push notifications. | ||
* | ||
* @param senderDisplayName the senderDisplayName value to set. | ||
* @return the SendTypingNotificationRequest object itself. | ||
*/ | ||
public SendTypingNotificationRequest setSenderDisplayName(String senderDisplayName) { | ||
this.senderDisplayName = senderDisplayName; | ||
return this; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiminwen-msft did you change the description in the swagger JSON file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed json files in the spool gateway package. Not sure why it is not reflected while generating auto rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update here https://github.com/Azure/azure-rest-api-specs/tree/main/specification/communication/data-plane/Chat