Update autorest config #28558
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
|
||
| package com.azure.communication.chat.implementation.models; | ||
|
|
||
| import com.azure.core.annotation.Fluent; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| /** Request payload for typing notifications. */ | ||
| @Fluent | ||
| public final class SendTypingNotificationRequest { | ||
|
There was a problem hiding this comment. We already have this class as TypingNotificationOptions There was a problem hiding this comment. This transformation from the Swagger/Readme should've renamed it, if it doesn't anymore something might've changed: directive:
There was a problem hiding this comment.
|
||
| /* | ||
| * The display name of the typing notification sender. This property is | ||
| * used to populate sender name for push notifications. | ||
| */ | ||
| @JsonProperty(value = "senderDisplayName") | ||
| private String senderDisplayName; | ||
|
|
||
| /** | ||
| * Get the senderDisplayName property: The display name of the typing notification sender. This property is used to | ||
| * populate sender name for push notifications. | ||
| * | ||
| * @return the senderDisplayName value. | ||
| */ | ||
| public String getSenderDisplayName() { | ||
| return this.senderDisplayName; | ||
| } | ||
|
|
||
| /** | ||
| * Set the senderDisplayName property: The display name of the typing notification sender. This property is used to | ||
| * populate sender name for push notifications. | ||
| * | ||
| * @param senderDisplayName the senderDisplayName value to set. | ||
| * @return the SendTypingNotificationRequest object itself. | ||
| */ | ||
| public SendTypingNotificationRequest setSenderDisplayName(String senderDisplayName) { | ||
| this.senderDisplayName = senderDisplayName; | ||
| return this; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiminwen-msft did you change the description in the swagger JSON file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed json files in the spool gateway package. Not sure why it is not reflected while generating auto rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update here https://github.com/Azure/azure-rest-api-specs/tree/main/specification/communication/data-plane/Chat