Update autorest config #28558
Update autorest config #28558
Conversation
LuChen-Microsoft
requested review from
JianpingChen,
ankitarorabit,
minnieliu and
a team
as code owners
ghost
added
the
|
API change check for API changes are not detected in this pull request for |
| @@ -674,7 +674,7 @@ public Response<SendChatMessageResult> sendChatMessageWithResponse( | |||
| * Gets a list of messages from a thread. | |||
| * | |||
| * @param chatThreadId The thread id of the message. | |||
| * @param maxPageSize The maximum number of messages to be returned per page. The limit can be found at https://docs.microsoft.com/en-us/azure/communication-services/concepts/service-limits#size-limits. | |||
| * @param maxPageSize The maximum number of messages to be returned per page. | |||
| * @param startTime The earliest point in time to get messages up to. The timestamp should be in RFC3339 format: | |||
There was a problem hiding this comment.
@jiminwen-msft did you change the description in the swagger JSON file?
There was a problem hiding this comment.
I changed json files in the spool gateway package. Not sure why it is not reflected while generating auto rest.
There was a problem hiding this comment.
|
|
||
| /** Request payload for typing notifications. */ | ||
| @Fluent | ||
| public final class SendTypingNotificationRequest { |
There was a problem hiding this comment.
We already have this class as TypingNotificationOptions
There was a problem hiding this comment.
This transformation from the Swagger/Readme should've renamed it, if it doesn't anymore something might've changed:
directive:
- from: swagger-document
where: $.definitions
transform: >
if (!$.TypingNotificationOptions) {
$.TypingNotificationOptions = $ .SendTypingNotificationRequest;
delete $.TypingNotificationRequest;
} - from: swagger-document
where: $["paths"]["/chat/threads/{chatThreadId}/typing"].post.parameters[2]
transform: >
if ($.schema && $ .schema.$ref && $.schema.$ref.endsWith("SendTypingNotificationRequest")) {
const path = $.schema.$ref.replace(/[#].*$/, "#/definitions/TypingNotificationOptions");
$.schema = { "$ref": path };
}
There was a problem hiding this comment.
delete $.TypingNotificationRequest;
The delete param name is incorrect here. Fixed it in the new iteration.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines