Mgmt: make createAsync return Mono<ModelT> #15212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenTanyi
requested review from
weidongxu-microsoft,
xseeseesee and
yungezz
as code owners
weidongxu-microsoft
approved these changes
Sep 15, 2020
| @@ -94,7 +94,7 @@ public RoleAssignmentHelper withAccessTo(final String scope, final BuiltInRole a | |||
| .withBuiltInRole(asRole) | |||
| .withScope(resourceScope) | |||
| .createAsync() | |||
| .last() | |||
| .cast(Indexable.class) | |||
There was a problem hiding this comment.
Why need a cast? Does it need Flux<Indexable>?
There was a problem hiding this comment.
Some are dependency or post dependency, some are in test for Flux
...c/main/java/com/azure/resourcemanager/authorization/implementation/ServicePrincipalImpl.java
Outdated
Show resolved
Hide resolved
...compute/src/test/java/com/azure/resourcemanager/compute/VirtualMachinePopularImageTests.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/resourcemanager/appservice/samples/ManageWebAppSourceControlAsync.java
Outdated
Show resolved
Hide resolved
yungezz
approved these changes
Sep 16, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jul 22, 2021
[Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview (Azure#15212) * Adds base for updating Microsoft.Security from version preview/2021-05-01-preview to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * Create Multi cloud API * Minor typo fix * Schema change (offering type) * Change array to object in the examples * Rename to Security Connector * Fix files name errors * Remove softwareInventories (auto generated) * Update examples and naming * Update the enum type to string * Adds suppression to readme * Rever the readme.md basic information * Fix SecurityConnetor defenition link * Policy description update * Prettier file * Rename the minitor offering type * Fix typo in the put example * Fix conflict * Add CSPM as custom word * prettier files * Fix lint error - adding 200OK for delete * Update readme.md Add JAVA to swagger-to-sdk * Update the preview tag location * Rename the resource to SecurityConnectors Co-authored-by: Sapir Elmakayes <saelmaka@microsoft.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jul 22, 2021
Revert "[Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview (Azure#15212)" (Azure#15303) This reverts commit 463d63186066d7faeb1f74eda7fd380fa3cf9cf8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #15074
we don't need invoke order anyone, only add some comment in TaskGroup