Mgmt: fix playback fail #15074
Closed
Mgmt: fix playback fail #15074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenTanyi
requested review from
weidongxu-microsoft,
xseeseesee and
yungezz
as code owners
weidongxu-microsoft
approved these changes
Sep 11, 2020
| @@ -399,7 +400,15 @@ public void addPostRunDependentTaskGroup(TaskGroup dependentTaskGroup) { | |||
| } | |||
| readyTaskEntry = super.getNext(); | |||
| } | |||
| return Flux.mergeDelayError(32, observables.toArray(new Flux[0])); | |||
| return Flux.mergeOrdered(32, | |||
There was a problem hiding this comment.
There is some difference on "DelayError" part as well. Might need to check a bit on processFaultedTaskAsync method.
There was a problem hiding this comment.
mergeOrdered will automatically delay error to the last, due to it cannot compare item with error
There was a problem hiding this comment.
Added the mergeOrdered test about it.
There was a problem hiding this comment.
If convenient, try write a few tests for it (positive cases and negative cases)?
...er-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/dag/TaskGroup.java
Show resolved
Hide resolved
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Aug 2, 2021
[AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (Azure#15370) * Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Modify Swagger to fix the problem of automatically generating ugly names in track 2 (Azure#14758) * update swagger to fix track 2 autogenerated naming issue * fix * update readme for sdk generation * fix lint error * Trigger Build * update readme * Improve AKS Swagger documentation (Azure#14957) * Improve AKS Swagger documentation - This change has already been merged in master for the 2021-05-01 API version. * Fix up custom words * aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (Azure#15033) * fix: decouple pod identity provisioning error from cloud error * drop extra external mark * fix linting issue * fix reference * Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (Azure#15035) * Add SecurityProfile to ManagedClusters * spaces * Space * spaces * json formatting * move from params to defs * :) * just another * now with npm * Descriptions update for AKS July API (Azure#15074) * allow disabling of runcommand (Azure#15092) * allow disabling of runcommand * format error * format with example * change enable to disable * Revert "allow disabling of runcommand (Azure#15092)" (Azure#15147) This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9. * [AKS] Add NATGatewayProfile to 2021-07-01 API (Azure#15154) * [AKS] Add NATGatewayProfile to 2021-07-01 API * Fix linter errors Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> * Add scaleDownMode to agent pool properties (Azure#15124) * add scale down mode * address comments * fix markdown link * update proper api version * Resolve python markdown conflict & fix typo (Azure#15402) * resolve python conflict & fix typo * resolve conflict Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just use the most simple way the avoid the cast error (It will cause the return order is not topological order). Will raise an issue for refactor DAG, for topological order.