[DO NOT MERGE] Introducing Per-Site Waf Policy Support #6907

venkatsvpr · 2019-08-08T20:52:26Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…limit as 1, upper limit is based on the Skw and AppGw Version so we shouldnt enforce the upper limit

…P. Swagger only have to protect against potential negative values

Pulling latest Master to my repo

* Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments

…to publicIpPrefix (Azure#6693)

Pulling latest code changes

AutorestCI · 2019-08-08T20:54:33Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 862838d5dbe0b003ebbae3820a2a2a5eb8377476
  stderr: 'fatal: reference is not a tree: 862838d5dbe0b003ebbae3820a2a2a5eb8377476'

AutorestCI · 2019-08-08T21:27:39Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 862838d5dbe0b003ebbae3820a2a2a5eb8377476
  stderr: 'fatal: reference is not a tree: 862838d5dbe0b003ebbae3820a2a2a5eb8377476'

azuresdkci · 2019-08-08T21:29:29Z

Can one of the admins verify this patch?

anton-evseev · 2019-08-14T00:47:48Z

network-july-release has been merged, please rebase and retarget to master

openapi-sdkautomation · 2019-08-14T18:49:36Z

In Testing, Please Ignore

[Logs] (Generated from af749ae, Iteration 6)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Network [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.Network.19.14.0-preview.nupkg
- Microsoft.Azure.Management.Network.19.14.0-preview.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

…into perSiteUri

vkrivopalov

We also need to add firewallPolicy to ApplicationGatewayHttpListenerPropertiesFormat for the per-site case. The current cases cover per-URI scenario (routing rules) only.

vkrivopalov · 2019-08-21T22:07:03Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-06-01/applicationGateway.json

+        },
+        "firewallPolicy": {
+          "$ref": "./network.json#/definitions/SubResource",
+          "description": "Reference of the FirewallPolicy resource."


(minor) "Reference TO..."?

vkrivopalov · 2019-08-21T22:10:27Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-06-01/applicationGateway.json

@@ -1681,6 +1685,10 @@
          "$ref": "./network.json#/definitions/SubResource",
          "description": "Redirect configuration resource of the application gateway."
        },
+        "firewallPolicy": {


For routing rules of 'Basic' type we should add a map of new objects.
That new object should be similar to ApplicationGatewayPathRulePropertiesFormat but only have
"paths" and "firewallPolicy". We can have multiple path prefixes with different WAF policies per a single Basic rule.

yungezz · 2019-08-28T08:37:28Z

hi @venkatsvpr @zikalino what's the status on the PR?

venkatsvpr and others added 17 commits April 1, 2019 14:20

Swagger was enforcing the limit as 0 to 500, It should enforce lower …

fd3e027

…limit as 1, upper limit is based on the Skw and AppGw Version so we shouldnt enforce the upper limit

Currently 0 doesnt make sense.. but this check will be enforced by NR…

c99990b

…P. Swagger only have to protect against potential negative values

Merge pull request #1 from Azure/master

45faff4

Pulling latest Master to my repo

Fix typos in Network's examples (Azure#6740)

343d133

Add missing read-only property "loadBalancerFrontendIpConfiguration" …

748e335

…to publicIpPrefix (Azure#6693)

Make patch operations async for VNGs and VNG Connections (Azure#6695)

3e87f8a

Merge pull request #6 from Azure/network-july-release

b0b855e

Pulling latest code changes

Toplevel waf work checkin

9be4036

reverting the change made

12d8993

minor fixes

7310a97

Using the network.json/parameters/ApiVersionParameter

674c390

more changes

0a095c1

Changes in swagger

68ff603

Minor changes;

22d04a8

Adding firewall Policy to appGateway

5ae2295

taking the waf firewall out. .since this is taken by seperate PR

081723f

venkatsvpr requested a review from MikhailTryakhov as a code owner August 8, 2019 20:52

azuresdkci assigned zikalino Aug 8, 2019

azuresdkci requested a review from zikalino August 8, 2019 21:04

venkatsvpr changed the base branch from network-july-release to master August 14, 2019 18:49

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

18ac97c

…into perSiteUri

AutorestCI mentioned this pull request Aug 14, 2019

[AutoPR network/resource-manager] [DO NOT MERGE] Introducing Per-Site Waf Policy Support Azure/azure-sdk-for-go#5521

Closed

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] [DO NOT MERGE] Introducing Per-Site Waf Policy Support test-repo-tih/azure-rest-api-specs#120

Closed

vkrivopalov suggested changes Aug 21, 2019

View reviewed changes

venkatsvpr added 4 commits August 21, 2019 15:54

Fixing review comments

3b6036a

adding firewallpolicy to HttpListener

8995e5c

fixing model validations

145ef5f

Update the review comments and updating the swagger

af749ae

openapi-sdkautomation bot mentioned this pull request Aug 24, 2019

[AutoPR Microsoft.Azure.Management.Network] [DO NOT MERGE] Introducing Per-Site Waf Policy Support test-repo-billy/azure-sdk-for-net#139

Closed

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 28, 2019

venkatsvpr closed this Aug 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Introducing Per-Site Waf Policy Support #6907

[DO NOT MERGE] Introducing Per-Site Waf Policy Support #6907

venkatsvpr commented Aug 8, 2019

AutorestCI commented Aug 8, 2019 •

edited

Loading

AutorestCI commented Aug 8, 2019 •

edited

Loading

azuresdkci commented Aug 8, 2019

anton-evseev commented Aug 14, 2019

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading

vkrivopalov left a comment

vkrivopalov Aug 21, 2019

venkatsvpr Aug 21, 2019

vkrivopalov Aug 21, 2019

venkatsvpr Aug 21, 2019

yungezz commented Aug 28, 2019

[DO NOT MERGE] Introducing Per-Site Waf Policy Support #6907

[DO NOT MERGE] Introducing Per-Site Waf Policy Support #6907

Conversation

venkatsvpr commented Aug 8, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Aug 8, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 8, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Aug 8, 2019

anton-evseev commented Aug 14, 2019

openapi-sdkautomation bot commented Aug 14, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from af749ae, Iteration 6)

vkrivopalov left a comment

Choose a reason for hiding this comment

vkrivopalov Aug 21, 2019

Choose a reason for hiding this comment

venkatsvpr Aug 21, 2019

Choose a reason for hiding this comment

vkrivopalov Aug 21, 2019

Choose a reason for hiding this comment

venkatsvpr Aug 21, 2019

Choose a reason for hiding this comment

yungezz commented Aug 28, 2019

AutorestCI commented Aug 8, 2019 •

edited

Loading

AutorestCI commented Aug 8, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading