-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make patch operations async for VNGs and VNG Connections #6695
Make patch operations async for VNGs and VNG Connections #6695
Conversation
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpbiidnq5l/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpbiidnq5l/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .
<--- Last few GCs --->
[13257:0x3497cc0] 93050 ms: Mark-sweep 1380.0 (1424.9) -> 1379.6 (1425.4) MB, 1228.6 / 0.0 ms (average mu = 0.132, current mu = 0.015) allocation failure scavenge might not succeed
[13257:0x3497cc0] 94685 ms: Mark-sweep 1380.5 (1425.4) -> 1380.1 (1425.9) MB, 1632.5 / 0.0 ms (average mu = 0.062, current mu = 0.002) allocation failure scavenge might not succeed
<--- JS stacktrace --->
==== JS stack trace =========================================
0: ExitFrame [pc: 0x4225f45be1d]
Security context: 0x36fffe89e6e9 <JSObject>
1: Descendants [0x4bf97d88d1] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x4225f896eab](this=0x004bf97d5e99 <Object map = 0x2eb2c03e8d21>,/* anonymous */=0x18dfaa602801 <the_hole>,/* anonymous */=0x18dfaa602801 <the_hole>,/* anonymous */=0x18dfaa602801 <the_hole>)
...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x4225f45be1d |
Automation for azure-sdk-for-javaEncountered a Subprocess error: (azure-sdk-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpszbpw56t/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
Including configuration file 'file:///tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.java.md'
Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-04"} .
Including configuration file 'file:///tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.java.md'
<--- Last few GCs --->
[6427:0x412ebb0] 70781 ms: Mark-sweep 1378.5 (1425.3) -> 1378.3 (1424.8) MB, 1767.4 / 0.0 ms (average mu = 0.140, current mu = 0.030) allocation failure scavenge might not succeed
[6427:0x412ebb0] 71949 ms: Mark-sweep 1378.9 (1424.8) -> 1378.8 (1425.3) MB, 1166.5 / 0.0 ms (average mu = 0.085, current mu = 0.002) allocation failure scavenge might not succeed
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x086f4a51e6e9 <JSObject>
0: builtin exit frame: concat(this=0x18fcbb8dc361 <JSArray[38]>,0x18fcbb8dcf69 <JSArray[1]>,0x18fcbb8dc361 <JSArray[38]>)
1: Descendants [0xed48a17ba99] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x38dd4124f835](this=0x1516bccb6dd1 <Object map = 0x1d83b3ff4669>,/* anonymous */=0x0de36be02801 <the_hol...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xead6d1 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [node]
13: 0xead9cc v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
14: 0xe66e01 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [node]
15: 0xb63d99 [node]
16: 0xb6d498 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [node]
17: 0x38dd40e5bf7d |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json
Outdated
Show resolved
Hide resolved
...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergey-shandar can you please review & also help to find out why reviewer is not specified automatically? |
@MikhailTryakhov the assignment bot is fixed now to auto-assign network PRs. fyi, the problem is caused by network branches not whitelisted. |
@sergey-shandar - Can you please review this PR and merge it if you have no comments/suggestions? |
@yungezz sorry how to whitelist them? What's a practice to do that next time? Can we add it at the portal during monthly branch creation process? |
it's done in bot tool. the fix is not for this month only. the fix is making sure network branches all there, unless you changed branch naming convention. |
hmm... for some reason i can't approve this pr/ and merge button also gray... |
* Add swagger specification for firewall policy resource (#6708) * Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments * Fix typos in Network's examples (#6740) * Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693) * Make patch operations async for VNGs and VNG Connections (#6695) * fix: network 2019-06-01 model validation errror (#6790) Thumbprint -> thumbprint * Update definition of ApplicationGatewayOnDemandProbe (#6716) * Fix definition of ApplicationGatewayOnDemandProbe * minor changes * Copy fixed examples to 2019-02-01
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.