Make patch operations async for VNGs and VNG Connections #6695

ritwikbasu · 2019-07-22T18:56:00Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

[Y] I have reviewed the documentation for the workflow.
[Y] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[Y] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[Y] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[Y] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-07-22T18:58:00Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpbiidnq5l/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpbiidnq5l/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[13257:0x3497cc0]    93050 ms: Mark-sweep 1380.0 (1424.9) -> 1379.6 (1425.4) MB, 1228.6 / 0.0 ms  (average mu = 0.132, current mu = 0.015) allocation failure scavenge might not succeed
[13257:0x3497cc0]    94685 ms: Mark-sweep 1380.5 (1425.4) -> 1380.1 (1425.9) MB, 1632.5 / 0.0 ms  (average mu = 0.062, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x4225f45be1d]
Security context: 0x36fffe89e6e9 <JSObject>
    1: Descendants [0x4bf97d88d1] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x4225f896eab](this=0x004bf97d5e99 <Object map = 0x2eb2c03e8d21>,/* anonymous */=0x18dfaa602801 <the_hole>,/* anonymous */=0x18dfaa602801 <the_hole>,/* anonymous */=0x18dfaa602801 <the_hole>)
    ...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x4225f45be1d

AutorestCI · 2019-07-22T18:58:48Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpszbpw56t/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Including configuration file 'file:///tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.java.md'
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-04"} .
   Including configuration file 'file:///tmp/tmpszbpw56t/rest/specification/network/resource-manager/readme.java.md'

<--- Last few GCs --->

[6427:0x412ebb0]    70781 ms: Mark-sweep 1378.5 (1425.3) -> 1378.3 (1424.8) MB, 1767.4 / 0.0 ms  (average mu = 0.140, current mu = 0.030) allocation failure scavenge might not succeed
[6427:0x412ebb0]    71949 ms: Mark-sweep 1378.9 (1424.8) -> 1378.8 (1425.3) MB, 1166.5 / 0.0 ms  (average mu = 0.085, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x086f4a51e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x18fcbb8dc361 <JSArray[38]>,0x18fcbb8dcf69 <JSArray[1]>,0x18fcbb8dc361 <JSArray[38]>)

    1: Descendants [0xed48a17ba99] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x38dd4124f835](this=0x1516bccb6dd1 <Object map = 0x1d83b3ff4669>,/* anonymous */=0x0de36be02801 <the_hol...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xead6d1 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [node]
13: 0xead9cc v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
14: 0xe66e01 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [node]
15: 0xb63d99  [node]
16: 0xb6d498 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [node]
17: 0x38dd40e5bf7d

azuresdkci · 2019-07-22T19:02:42Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-22T19:28:44Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json

TianoMS

MikhailTryakhov · 2019-07-26T19:15:30Z

@sergey-shandar can you please review & also help to find out why reviewer is not specified automatically?

yungezz · 2019-07-31T02:17:34Z

@MikhailTryakhov the assignment bot is fixed now to auto-assign network PRs. fyi, the problem is caused by network branches not whitelisted.

ritwikbasu · 2019-07-31T19:36:18Z

@sergey-shandar - Can you please review this PR and merge it if you have no comments/suggestions?

MikhailTryakhov · 2019-07-31T21:34:28Z

@yungezz sorry how to whitelist them? What's a practice to do that next time? Can we add it at the portal during monthly branch creation process?

yungezz · 2019-08-01T01:58:54Z

@yungezz sorry how to whitelist them? What's a practice to do that next time? Can we add it at the portal during monthly branch creation process?

it's done in bot tool. the fix is not for this month only. the fix is making sure network branches all there, unless you changed branch naming convention.

zikalino · 2019-08-01T16:42:20Z

hmm... for some reason i can't approve this pr/ and merge button also gray...

* Add swagger specification for firewall policy resource (#6708) * Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments * Fix typos in Network's examples (#6740) * Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693) * Make patch operations async for VNGs and VNG Connections (#6695) * fix: network 2019-06-01 model validation errror (#6790) Thumbprint -> thumbprint * Update definition of ApplicationGatewayOnDemandProbe (#6716) * Fix definition of ApplicationGatewayOnDemandProbe * minor changes * Copy fixed examples to 2019-02-01

Make patch operations async for VNGs and VNG Connections

d1dadc2

ritwikbasu requested a review from MikhailTryakhov as a code owner July 22, 2019 18:56

TianoMS reviewed Jul 23, 2019

View reviewed changes

...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json Outdated Show resolved Hide resolved

TianoMS reviewed Jul 23, 2019

View reviewed changes

...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json Outdated Show resolved Hide resolved

Review Comments - Remove body for 202 response

944413b

TianoMS approved these changes Jul 23, 2019

View reviewed changes

anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 23, 2019

MikhailTryakhov requested a review from sergey-shandar July 26, 2019 19:13

yungezz assigned zikalino Jul 29, 2019

zikalino self-requested a review August 1, 2019 16:40

zikalino approved these changes Aug 2, 2019

View reviewed changes

yungezz merged commit 3e87f8a into Azure:network-july-release Aug 2, 2019

ritwikbasu mentioned this pull request Jun 12, 2020

Make patch operations async for VirtualWAN VpnGateways and P2SVpnGateways. #9833

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make patch operations async for VNGs and VNG Connections #6695

Make patch operations async for VNGs and VNG Connections #6695

ritwikbasu commented Jul 22, 2019

AutorestCI commented Jul 22, 2019 •

edited

Loading

AutorestCI commented Jul 22, 2019 •

edited

Loading

azuresdkci commented Jul 22, 2019

AutorestCI commented Jul 22, 2019 •

edited

Loading

TianoMS left a comment

MikhailTryakhov commented Jul 26, 2019

yungezz commented Jul 31, 2019

ritwikbasu commented Jul 31, 2019

MikhailTryakhov commented Jul 31, 2019

yungezz commented Aug 1, 2019

zikalino commented Aug 1, 2019

Make patch operations async for VNGs and VNG Connections #6695

Make patch operations async for VNGs and VNG Connections #6695

Conversation

ritwikbasu commented Jul 22, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jul 22, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 22, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jul 22, 2019

AutorestCI commented Jul 22, 2019 • edited Loading

Automation for azure-sdk-for-go

TianoMS left a comment

Choose a reason for hiding this comment

MikhailTryakhov commented Jul 26, 2019

yungezz commented Jul 31, 2019

ritwikbasu commented Jul 31, 2019

MikhailTryakhov commented Jul 31, 2019

yungezz commented Aug 1, 2019

zikalino commented Aug 1, 2019

AutorestCI commented Jul 22, 2019 •

edited

Loading

AutorestCI commented Jul 22, 2019 •

edited

Loading

AutorestCI commented Jul 22, 2019 •

edited

Loading