[DO NOT MERGE] ToplevelWaf Swagger Changes #6851

venkatsvpr · 2019-08-02T06:58:50Z

Previous PRs:
[Link to Previous PR] (#5990)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…limit as 1, upper limit is based on the Skw and AppGw Version so we shouldnt enforce the upper limit

…P. Swagger only have to protect against potential negative values

Pulling latest Master to my repo

* Add swagger specification for firewall policy resource * Add the firewall policy spec to the list of files in readme.md * Add priority to the Filter Rule in example for Rule Group Get * Encapsulate the response body in a body property * Suppress errors due to missing properties inhertied from base resource: * Fix typo * Fix Build errors * Address review comments * Revert capitalization of Tags and OperationId as Semantic valiation expects lower case * Drop 201 response from examples * Capitalize first letter of the operationId and tags values * Add swagger changes for azure firewall in vHub * Add a ref to the example file for Azure Firewall in vHub * Fix validation check * Address review comments

…to publicIpPrefix (Azure#6693)

Pulling latest code changes

venkatsvpr · 2019-08-02T06:59:25Z

Please do not checkin - Have to get signoff from AFD and the portal team.

AutorestCI · 2019-08-02T07:00:50Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c7d9139de5bef65a50be1d65d9a7fe2f688721ba
  stderr: 'fatal: reference is not a tree: c7d9139de5bef65a50be1d65d9a7fe2f688721ba'

azuresdkci · 2019-08-02T07:04:11Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-02T07:31:52Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c7d9139de5bef65a50be1d65d9a7fe2f688721ba
  stderr: 'fatal: reference is not a tree: c7d9139de5bef65a50be1d65d9a7fe2f688721ba'

PhoenixHe-NV · 2019-08-02T09:15:44Z

@OpenAPIBot sdkautomation rebuild

...ion/network/resource-manager/Microsoft.Network/stable/2019-06-01/webapplicationfirewall.json

anton-evseev · 2019-08-05T19:51:12Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-06-01/webapplicationfirewall.json

+        },
+        "exclusions":{
+          "description": "Describes the Exclusions that are applied on the policy.",
+          "$ref": "#/defintions/CrsExclusions"


Typo in defintions. Also, you don't really need to move this to definitions. This code would be fine:

"exclusions": { "type": "array", "items": { "$ref": "#/definitions/CrsExclusionEntry" }, "description": "Describes the Exclusions that are applied on the policy." }

anton-evseev · 2019-08-06T18:28:10Z

@venkatsvpr please double check your commits, there seems to be a lot of unrelated changes. The CI is also failing because it can't resolve definition ManagedRuleSetsList

anton-evseev · 2019-08-14T00:47:41Z

network-july-release has been merged, please rebase and retarget to master

openapi-sdkautomation · 2019-08-14T14:39:13Z

In Testing, Please Ignore

[Logs] (Generated from 07caab8, Iteration 5)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

…into network-july-release

yungezz · 2019-08-28T07:59:16Z

Hi @venkatsvpr could you pls update this PR?

MikhailTryakhov · 2019-08-29T03:38:14Z

closing due to NRP 2019-08-01 branch is not ready yet. we've asked owner to change when branch would be ready in a month

venkatsvpr and others added 10 commits April 1, 2019 14:20

Swagger was enforcing the limit as 0 to 500, It should enforce lower …

fd3e027

…limit as 1, upper limit is based on the Skw and AppGw Version so we shouldnt enforce the upper limit

Currently 0 doesnt make sense.. but this check will be enforced by NR…

c99990b

…P. Swagger only have to protect against potential negative values

Merge pull request #1 from Azure/master

45faff4

Pulling latest Master to my repo

Fix typos in Network's examples (Azure#6740)

343d133

Add missing read-only property "loadBalancerFrontendIpConfiguration" …

748e335

…to publicIpPrefix (Azure#6693)

Make patch operations async for VNGs and VNG Connections (Azure#6695)

3e87f8a

Merge pull request #6 from Azure/network-july-release

b0b855e

Pulling latest code changes

Toplevel waf work checkin

9be4036

reverting the change made

12d8993

venkatsvpr requested a review from MikhailTryakhov as a code owner August 2, 2019 06:58

azuresdkci assigned tjprescott Aug 2, 2019

azuresdkci requested a review from tjprescott August 2, 2019 07:00

anton-evseev suggested changes Aug 5, 2019

View reviewed changes

venkatsvpr added 3 commits August 5, 2019 15:09

minor fixes

7310a97

Using the network.json/parameters/ApiVersionParameter

674c390

more changes

0a095c1

venkatsvpr and others added 3 commits August 6, 2019 15:41

Changes in swagger

68ff603

Minor changes;

22d04a8

Prettify JSON

5399963

anton-evseev self-requested a review August 12, 2019 19:16

anton-evseev approved these changes Aug 12, 2019

View reviewed changes

venkatsvpr added 2 commits August 13, 2019 16:58

Introducing enums in Exclusion Entry

9346ab3

Minor Fixes; keeping it as state

2bf8e6e

Updating the swagger Api?

97cc32f

venkatsvpr changed the base branch from network-july-release to master August 14, 2019 14:39

venkatsvpr added 2 commits August 14, 2019 08:03

updates to the swagger

1ac5aac

Fixing the typo in the json

24b04a2

AutorestCI mentioned this pull request Aug 14, 2019

[AutoPR network/resource-manager] [DO NOT MERGE] ToplevelWaf Swagger Changes Azure/azure-sdk-for-go#5518

Closed

venkatsvpr added 2 commits August 14, 2019 11:18

fixes on the swagger

b55903a

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

07caab8

…into network-july-release

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] [DO NOT MERGE] ToplevelWaf Swagger Changes test-repo-tih/azure-rest-api-specs#134

Closed

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 28, 2019

MikhailTryakhov closed this Aug 29, 2019

venkatsvpr mentioned this pull request Sep 16, 2019

Top Level WAF Swagger Changes #7222

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] ToplevelWaf Swagger Changes #6851

[DO NOT MERGE] ToplevelWaf Swagger Changes #6851

venkatsvpr commented Aug 2, 2019

venkatsvpr commented Aug 2, 2019 •

edited

Loading

AutorestCI commented Aug 2, 2019 •

edited

Loading

azuresdkci commented Aug 2, 2019

AutorestCI commented Aug 2, 2019 •

edited

Loading

PhoenixHe-NV commented Aug 2, 2019

anton-evseev Aug 5, 2019

venkatsvpr Aug 5, 2019

anton-evseev commented Aug 6, 2019

anton-evseev commented Aug 14, 2019

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading

yungezz commented Aug 28, 2019

MikhailTryakhov commented Aug 29, 2019

[DO NOT MERGE] ToplevelWaf Swagger Changes #6851

[DO NOT MERGE] ToplevelWaf Swagger Changes #6851

Conversation

venkatsvpr commented Aug 2, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

venkatsvpr commented Aug 2, 2019 • edited Loading

AutorestCI commented Aug 2, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 2, 2019

AutorestCI commented Aug 2, 2019 • edited Loading

Automation for azure-sdk-for-go

PhoenixHe-NV commented Aug 2, 2019

anton-evseev Aug 5, 2019

Choose a reason for hiding this comment

venkatsvpr Aug 5, 2019

Choose a reason for hiding this comment

anton-evseev commented Aug 6, 2019

anton-evseev commented Aug 14, 2019

openapi-sdkautomation bot commented Aug 14, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 07caab8, Iteration 5)

yungezz commented Aug 28, 2019

MikhailTryakhov commented Aug 29, 2019

venkatsvpr commented Aug 2, 2019 •

edited

Loading

AutorestCI commented Aug 2, 2019 •

edited

Loading

AutorestCI commented Aug 2, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading