Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the NorthSouth API for Public Preview #4932

Merged
merged 21 commits into from
Mar 25, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
437fd70
Adding the NorthSouth API for Public Preview
Dec 16, 2018
60f423c
Fixed some JSON schema validation errors discovered by Open API HUB
Dec 16, 2018
8b757a2
Fixed bad indenetation + missing API method
Dec 16, 2018
2005269
Added missing NorthSouthResourceName parameter definition
Dec 16, 2018
6f1e5a9
Fixed typos found in CR
Dec 17, 2018
65fea15
Added EnforceTrafficHardeningRules action
Dec 17, 2018
a582baa
Fixed invalid action name in URI discovered by ARM validation tools (…
Dec 17, 2018
ff15ca3
Renamed NorthSouthHardenings to AdaptiveNetworkControls and fixed iss…
Jan 15, 2019
2f29b6f
Fixed a bad reference to ListByExtendedResourceAdaptiveNetworkControl…
Jan 15, 2019
57ef341
Changes AdaptiveNetworkControls protocol property to array instead of…
Jan 15, 2019
84f9472
Moving 'x-ms-long-running-operation' to the right location
Jan 15, 2019
33bdd8a
Fixing R2005 LongRunningResponseStatusCode error on AdaptiveNetworkCo…
Jan 16, 2019
2e6d2ab
Updating EnforceAdaptiveNetworkControlsRules_example.json with the ne…
Jan 16, 2019
03ec6bc
Merged from master
Mar 5, 2019
eb822ba
Renamed AdaptiveNetworkControls to AdaptiveNetworkHardenings due to m…
Mar 5, 2019
0b7b156
Merge branch 'Azure-master'
Mar 5, 2019
c2cdb72
Fixing an invalid reference to CloudError
Mar 5, 2019
69d5e7e
Renaming the parameters and paths so only collection resources will b…
Mar 5, 2019
b31b187
aligned all operation ids
Mar 7, 2019
408ebd9
Adding enforce request body schema
Mar 8, 2019
0efd3e5
Adding Adaptive Network Hardenings to Security readme.md
Mar 25, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,5 @@ AutoRest.*
output/*
errors.txt
warnings.txt

/dist/
6 changes: 4 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '8'
- '10'
services:
- docker
env:
Expand All @@ -16,8 +16,9 @@ env:
- MODE=semantic PR_ONLY=true CHECK_NAME="Semantic Validator"
- MODE=semantic PR_ONLY=false
- MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
# - MODE=model PR_ONLY=false
- MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
- MODE=lintdiff PR_ONLY=true CHECK_NAME="Linter Diff"
- MODE=lintdiff PR_ONLY=true CHECK_NAME="Linter Diff" NODE_OPTIONS=--max-old-space-size=8192
matrix:
fast_finish: true
allow_failures:
Expand All @@ -27,6 +28,7 @@ matrix:
- env: MODE=java CHECK_NAME="SDK Generation - Java"
- env: MODE=go CHECK_NAME="SDK Generation - Go"
- env: MODE=semantic PR_ONLY=false
- env: MODE=model PR_ONLY=false
- env: MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
- env: MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
install: true
Expand Down
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/specification/consumption/ @kjeur @panda-wang
/specification/containerinstance/ @samkreter
/specification/containerregistry/ @djyou
/specification/containerservices/ @mboersma
/specification/containerservice/ @mboersma
/specification/cosmos-db/ @dmakwana
/specification/customer-insights/ @tjlvtao
/specification/datafactory/ @zhangyd2015
Expand Down
6 changes: 3 additions & 3 deletions arm-compute/quickstart-templates/aliases.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"Debian":{
"publisher":"credativ",
"offer":"Debian",
"sku":"8",
"sku":"9",
"version":"latest"
},
"openSUSE-Leap": {
Expand All @@ -44,13 +44,13 @@
"SLES":{
"publisher":"SUSE",
"offer":"SLES",
"sku":"12-SP2",
"sku":"15",
"version":"latest"
},
"UbuntuLTS":{
"publisher":"Canonical",
"offer":"UbuntuServer",
"sku":"16.04-LTS",
"sku":"18.04-LTS",
"version":"latest"
}
},
Expand Down
112 changes: 112 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
name: "Azure OpenAPI"

trigger: none

variables:
TRAVIS: 'true'
TRAVIS_BRANCH: $(System.PullRequest.TargetBranch)
TRAVIS_PULL_REQUEST: $(System.PullRequest.PullRequestNumber)
TRAVIS_REPO_SLUG: $(Build.Repository.Name)
TRAVIS_PULL_REQUEST_SLUG: $(Build.Repository.Name)
TRAVIS_PULL_REQUEST_SHA: $(Build.SourceVersion)
PR_ONLY: 'true'

jobs:

- job: "Syntax"
pool:
vmImage: 'Ubuntu 16.04'
steps:
- script: |
echo TRAVIS: $(TRAVIS)
echo TRAVIS_BRANCH: $(TRAVIS_BRANCH)
echo TRAVIS_REPO_SLUG: $(TRAVIS_REPO_SLUG)
echo TRAVIS_PULL_REQUEST: $(TRAVIS_PULL_REQUEST)
echo TRAVIS_PULL_REQUEST_SLUG: $(TRAVIS_PULL_REQUEST_SLUG)
echo TRAVIS_PULL_REQUEST_SHA: $(TRAVIS_PULL_REQUEST_SHA)
echo PR_ONLY: $(PR_ONLY)
displayName: "Info"
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'npm test -- test/syntax.js'
displayName: 'Syntax validation'

- job: "Semantic"
pool:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'node scripts/semanticValidation.js'
displayName: 'Semantic Validation'

- job: "ModelValidation"
pool:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'node scripts/modelValidation.js'
displayName: 'Model Validation'

- job: "BreakingChange"
pool:
vmImage: 'Ubuntu 16.04'
steps:
- script: 'scripts/install-dotnet.sh'
displayName: 'Insall .Net'
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'node scripts/breaking-change.js'
displayName: 'Breaking Changes'

- job: "LintDiff"
variables:
NODE_OPTIONS: '--max-old-space-size=8192'
pool:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'scripts/install-dotnet.sh'
displayName: 'install .Net'
- script: 'node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js'
displayName: 'LintDiff'

- job: "SDK"
timeoutInMinutes: 120
strategy:
matrix:
ruby:
AZURE_SDK_REPO: azure-sdk-for-ruby
AZURE_SDK_PARAMS: ''
java:
AZURE_SDK_REPO: azure-sdk-for-java
AZURE_SDK_PARAMS: ''
javascript:
AZURE_SDK_REPO: azure-sdk-for-js
AZURE_SDK_PARAMS: ''
node:
AZURE_SDK_REPO: azure-sdk-for-node
AZURE_SDK_PARAMS: ''
python:
AZURE_SDK_REPO: azure-sdk-for-python
AZURE_SDK_PARAMS: ''
go:
AZURE_SDK_REPO: azure-sdk-for-go
AZURE_SDK_PARAMS: '-o latest'
pool:
vmImage: 'Ubuntu 16.04'
steps:
- script: "scripts/swagger-to-sdk.sh Azure/$(AZURE_SDK_REPO) -v $(AZURE_SDK_PARAMS)"
displayName: "Swagger to SDK script"
4 changes: 2 additions & 2 deletions documentation/openapi-authoring-automated-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ We request OpenAPI(Swagger) spec authoring be assigned to engineers who have an

| Id | Rule Name | Applies to |
| --- | --- | --- |
| [R4000](#r4000-2) | [ParameterDescriptionRequired](#r4000-2) | ARM and Data plane OpenAPI(swagger) specs |
| [R4000](#r4000) | [ParameterDescriptionRequired](#r4000) | ARM and Data plane OpenAPI(swagger) specs |
| [R4000](#r4000-3) | [DescriptiveDescriptionRequired](#r4000-3) | ARM and Data plane OpenAPI(swagger) specs |
| [R4000](#r4000-4) | [DescriptionAndTitleMissing](#r4000-4) | ARM and Data plane OpenAPI(swagger) specs |
| [R4000](#r4000-5) | [OperationDescriptionOrSummaryRequired](#r4000-5) | ARM and Data plane OpenAPI(swagger) specs |
Expand Down Expand Up @@ -1662,7 +1662,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul

Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)

### <a name="r4000-2" />R4000 ParameterDescriptionRequired
### <a name="r4000" />R4000 ParameterDescriptionRequired
**Category** : SDK Warning

**Applies to** : ARM and Data plane OpenAPI(swagger) specs
Expand Down
15 changes: 10 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,21 @@
"@microsoft.azure/async-io": "^1.0.21",
"@microsoft.azure/literate": "^1.0.21",
"@microsoft.azure/polyfill": "^1.0.17",
"@ts-common/local-install": "^0.0.8",
"@ts-common/commonmark-to-markdown": "^1.1.9",
"@ts-common/fs": "0.1.0",
"@types/js-yaml": "^3.12.0",
"fs-extra": "^3.0.1",
"glob": "^5.0.14",
"js-yaml": "^3.8.2",
"json-schema-ref-parser": "^3.1.2",
"mocha": "*",
"oad": "^0.1.11",
"oav": "^0.9.6",
"oad": "0.1.12",
"oav": "^0.13.4",
"request": "^2.61.0",
"request-promise-native": "^1.0.5",
"z-schema": "^3.24.2"
"typescript": "^3.2.4",
"z-schema": "^3.25.0",
"ts-node": "^8.0.1"
},
"dependencies": {
"@octokit/rest": "^15.2.6"
Expand All @@ -39,6 +43,7 @@
"scripts": {
"test": "mocha -t 500000 --reporter min",
"oav": "oav",
"li": "local-install"
"tsc": "tsc",
"multiapi": "ts-node ./scripts/multiapi.ts"
}
}
Loading