-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the NorthSouth API for Public Preview #4932
Conversation
If you're a MSFT employee, click this link |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json
Outdated
Show resolved
Hide resolved
...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json
Outdated
Show resolved
Hide resolved
@MatanShabtay have these APIs been reviewed by ARM? |
This resource type exists in the manifest and it's swagger was reviewed in the PR below, however the PR wasn't completed as this resource is currently in private preview. We are working towards public preview and following recent changes in the requirements, the API completely changed. Once you confirm the PR please ask ARM to review as well. |
@ravbhatnagar FYI for ARM review. |
Hi, Apologies for the late push but I just noticed that I forgot to add a POST action on the resource so I've added it. Thanks in advance. |
…enforce to trafficHardeningsRulesEnforceAction)
Hi @jhendrixMSFT & @KrisBash , Due to marketing decisions I have renamed the resource type name to adaptiveNetworkHardenings from adaptiveNetworkControls & resolved the merge conflicts. Please review before we will update the manifest and add the new resource type |
...esource-manager/Microsoft.Security/preview/2015-06-01-preview/adaptiveNetworkHardenings.json
Outdated
Show resolved
Hide resolved
…e named in plural
...esource-manager/Microsoft.Security/preview/2015-06-01-preview/adaptiveNetworkHardenings.json
Outdated
Show resolved
Hide resolved
Hey @jhendrixMSFT , waiting for your approval. Thanks. |
@MatanShabtay has this functionality been deployed yet? I still see DoNotMerge label |
REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working with us on this review. LGTM
Automation for azure-sdk-for-netA PR has been created for you: |
@MatanShabtay hello any update? |
Hi @jhendrixMSFT , The API has been deployed and we ready to complete this PR. |
@MatanShabtay I don't see the new swagger referenced in the readme.md file so some SDK won't get the new APIs generated for them. Is this intentional? |
REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit
Hey, I've fixed it. Can you please confirm this ? |
@MatanShabtay it's not but has been fixed in a separate PR. |
* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit
* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4932' REST Spec PR Author 'MatanShabtay' REST Spec PR Last commit
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.