Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the NorthSouth API for Public Preview #4932

Merged
merged 21 commits into from
Mar 25, 2019
Merged

Adding the NorthSouth API for Public Preview #4932

merged 21 commits into from
Mar 25, 2019

Conversation

MatanShabtay
Copy link
Contributor

@MatanShabtay MatanShabtay commented Dec 16, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4374

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1765

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3782

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#5044

@AutorestCI
Copy link

AutorestCI commented Dec 16, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

This was referenced Dec 16, 2018
Closed
Closed
Closed
Closed
@chlahav chlahav self-requested a review December 16, 2018 14:22
@chlahav chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 16, 2018
@jhendrixMSFT
Copy link
Member

@MatanShabtay have these APIs been reviewed by ARM?

@MatanShabtay
Copy link
Contributor Author

@MatanShabtay have these APIs been reviewed by ARM?

This resource type exists in the manifest and it's swagger was reviewed in the PR below, however the PR wasn't completed as this resource is currently in private preview.

We are working towards public preview and following recent changes in the requirements, the API completely changed.
Note that its not considered as a breaking change since we are still under private preview.

#3669

Once you confirm the PR please ask ARM to review as well.
Thanks.

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 17, 2018
@jhendrixMSFT
Copy link
Member

@ravbhatnagar FYI for ARM review.

@MatanShabtay
Copy link
Contributor Author

Hi,

Apologies for the late push but I just noticed that I forgot to add a POST action on the resource so I've added it.
Hopefully I didn't cause any trouble.

Thanks in advance.

Fixed invalid action name in URI discovered by ARM validation tools (…
a582baa 
…enforce to trafficHardeningsRulesEnforceAction)
@MatanShabtay
Copy link
Contributor Author

Hi @jhendrixMSFT & @KrisBash , Due to marketing decisions I have renamed the resource type name to adaptiveNetworkHardenings from adaptiveNetworkControls & resolved the merge conflicts.

Please review before we will update the manifest and add the new resource type

@MatanShabtay
Copy link
Contributor Author

Hey @jhendrixMSFT , waiting for your approval.
Can you then refer someone from ARV to review?

Thanks.

This was referenced Mar 7, 2019
Closed
Closed
@jhendrixMSFT
Copy link
Member

@MatanShabtay has this functionality been deployed yet? I still see DoNotMerge label

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 8, 2019
@adxsdknet
.NET SDK Resource Provider:'SecurityCenter'
3f8ddd4 
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit
KrisBash
KrisBash approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working with us on this review. LGTM

@adxsdknet
Copy link

adxsdknet commented Mar 11, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5339
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@3f8ddd4
adxsdknet/azure-sdk-for-net@d83a479

@jhendrixMSFT
Copy link
Member

@MatanShabtay hello any update?

@chlahav chlahav removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 24, 2019
@chlahav chlahav changed the title [DO NOT MERGE] Adding the NorthSouth API for Public Preview Adding the NorthSouth API for Public Preview Mar 24, 2019
@MatanShabtay
Copy link
Contributor Author

Hi @jhendrixMSFT ,

The API has been deployed and we ready to complete this PR.
Thanks.

@jhendrixMSFT
Copy link
Member

@MatanShabtay I don't see the new swagger referenced in the readme.md file so some SDK won't get the new APIs generated for them. Is this intentional?

This was referenced Mar 25, 2019
Merged
Merged
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 25, 2019
@adxsdknet
.NET SDK Resource Provider:'SecurityCenter'
d83a479 
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit
@MatanShabtay
Copy link
Contributor Author

@MatanShabtay I don't see the new swagger referenced in the readme.md file so some SDK won't get the new APIs generated for them. Is this intentional?

Hey, I've fixed it.
I see that the Avocado check is failing but based on the error message it doesnt to be related to my PR.

Can you please confirm this ?

@jhendrixMSFT
Copy link
Member

@MatanShabtay it's not but has been fixed in a separate PR.

@jhendrixMSFT jhendrixMSFT merged commit 1acdb0b into Azure:master Mar 25, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 25, 2019
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 25, 2019
@adxsdknet @dsgouda
AutoPr-SecurityCenter-MatanShabtay-REST Spec PrNumber 4932 (#5339)
8045a80 
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-SecurityCenter-MatanShabtay-REST Spec PrNumber 4932 (Azure#5339)
685fe0a 
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#4932'
REST Spec PR Author 'MatanShabtay'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@KrisBash KrisBash KrisBash approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@chlahav chlahav Awaiting requested review from chlahav

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MatanShabtay @azuresdkci @AutorestCI @jhendrixMSFT @KrisBash @adxsdknet @nschonni @chlahav @kpajdzik