-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change payload-flattening-threshold from 2 to 1 #3758
change payload-flattening-threshold from 2 to 1 #3758
Conversation
payload-flattening-threshold
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
@ankushbindlish2 this's potential SDK breaking changes. Is there a reason to do so? |
It is not. Fixed the indentation, if that created confusion |
@shahabhijeet please, review the PR. I mean increasing flattering-threshold could introduce SDK breaking changes for stable API. |
@ankushbindlish2 could you also add codeowners for this RP https://github.com/Azure/azure-rest-api-specs/blob/master/CODEOWNERS ? |
no, not aware of this process... |
@ankushbindlish2 could you add couple of people from your team who should be responsible for reviewing changes in |
@dsgouda please, review |
payload-flattening-threshold
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger