Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change payload-flattening-threshold from 2 to 1 #3758

Merged
merged 3 commits into from
Aug 29, 2018
Merged

change payload-flattening-threshold from 2 to 1 #3758

merged 3 commits into from
Aug 29, 2018

Conversation

ankushbindlish2
Copy link
Member

payload-flattening-threshold

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

payload-flattening-threshold
@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2734

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3461

@sergey-shandar
Copy link
Contributor

@ankushbindlish2 this's potential SDK breaking changes. Is there a reason to do so?

@ankushbindlish2
Copy link
Member Author

It is not. Fixed the indentation, if that created confusion

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Aug 29, 2018

@shahabhijeet please, review the PR. I mean increasing flattering-threshold could introduce SDK breaking changes for stable API.

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Aug 29, 2018

@ankushbindlish2 could you also add codeowners for this RP https://github.com/Azure/azure-rest-api-specs/blob/master/CODEOWNERS ?

@ankushbindlish2
Copy link
Member Author

no, not aware of this process...

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Aug 29, 2018

@ankushbindlish2 could you add couple of people from your team who should be responsible for reviewing changes in storagesync?

@sergey-shandar
Copy link
Contributor

#3764

@sergey-shandar
Copy link
Contributor

@dsgouda please, review

@sergey-shandar sergey-shandar merged commit 25a49cb into Azure:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants