Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #3764

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Update CODEOWNERS #3764

merged 1 commit into from
Aug 29, 2018

Conversation

sergey-shandar
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@sergey-shandar sergey-shandar mentioned this pull request Aug 29, 2018
Merged
10 tasks
dsgouda
dsgouda approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 7b95fd7 into master Aug 29, 2018
@sergey-shandar sergey-shandar deleted the sergey-shandar-patch-4 branch August 29, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@ankushbindlish2 ankushbindlish2 ankushbindlish2 approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergey-shandar @AutorestCI @dsgouda @ankushbindlish2