Introducing new API for Azure Security Center Settings #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
chlahav
added
the
DoNotMerge
jianghaolu
suggested changes
Jul 26, 2018
| "api-version": "2017-08-01-preview", | ||
| "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23", | ||
| "settingName": "MCAS", | ||
| "setting": { |
There was a problem hiding this comment.
You are right changed parameter in example and in parameter definition to match.
…r definition - changes typo comment on settings get all example reference
chlahav
reviewed
Jul 30, 2018
| } | ||
| } | ||
| }, | ||
| "Settings": { |
There was a problem hiding this comment.
Settings [](start = 9, length = 8)
Setting
There was a problem hiding this comment.
Changes all single settings to setting
chlahav
reviewed
Jul 30, 2018
| "modelAsString": true, | ||
| "values": [ | ||
| { | ||
| "value": "DataExportSettings" |
There was a problem hiding this comment.
DataExportSettings [](start = 42, length = 18)
can also be DataExport since you are in the context of a setting
There was a problem hiding this comment.
Changes all single settings to setting
chlahav
reviewed
Jul 30, 2018
| "$ref": "#/parameters/SettingName" | ||
| }, | ||
| { | ||
| "$ref": "#/definitions/Settings" |
There was a problem hiding this comment.
definitions [](start = 35, length = 11)
create a parameter and reference it here instead of the definition
jianghaolu
approved these changes
Jul 30, 2018
|
Can one of the admins verify this patch? |
ravbhatnagar
added
the
ARMSignedOff
ghost
changed the title
|
@jianghaolu , we would like to merge our PR. |
ncalagar
pushed a commit
to ncalagar/azure-rest-api-specs
that referenced
this pull request
Aug 28, 2018
* Remove TrackedResource from Swagger spec "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource" * More updates on referring common types More updates on referring common types * Add UpdateParameters and Updateproperties * Update example * updated example * update examples Introducing new API for Azure Security Center Settings (Azure#3511) * Add new API for Azure Security Center Settings * Changed SettingsPUT API to receive parameter and not definition. * - changed settings parameter name in example and in security parameter definition - changes typo comment on settings get all example reference * changes settings to setting in Settings API * settings kind to setting kind in settings CSM API Update batch resource-manager Node.js package version to 3.1.2 (Azure#3732) IoTHub conf py (Azure#3733) Reports API moved from stable to preview version with addition of documentation of a couple of new APIs (Azure#3640) * Consumption specifications for cost insights and reporting operations * Fixed $ref for ReportConfigDelete * Silly me!! Fixed bad reference again * Fixed schema validation issues * Fixing validation errors around datetime and dynamic respones * Fixed parameters in examples * Fixed parameter name in example * Removed x-ms-odata method for POST op * Fixed ARM review comments * Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament * Merged with master again * Updated reports api documentation * Undo remove of API from stable version providing description for new introduced property isRecurringCharge fix example issues Microsoft.ResourceGraph public preview spec (Azure#3716) Add new microsoft.logic version (Azure#3683) * Copy of the source version (2016-06-01) to seed the new version (2018-07-01-preview) * Update Microsoft.Logic from 2016-06-01 to 2018-07-01-preview * Remove extra prep files, update the readme Fix Go SDK codegen for containerinstance (Azure#3735) The package-2018-06 tag was incorrecly using the 2018-04 tag. Moved Go SDK config section to its own config file. Microsoft.NetApp first version (Azure#3639) * Microsoft.NetApp first version * Addressing pullrequest comments added back billingperiod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger