Reports API moved from stable to preview version with addition of documentation of a couple of new APIs #3640

shalinved · 2018-08-14T21:19:39Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…oft.costmanagament

azuresdkci · 2018-08-14T21:20:07Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-14T21:20:16Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2924

AutorestCI · 2018-08-14T21:20:38Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-14T21:21:16Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-08-14T21:21:35Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-14T21:23:26Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2546

shalinved · 2018-08-14T21:45:11Z

@ravbhatnagar, @ms-premp

ravbhatnagar · 2018-08-20T18:17:17Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-09-01-preview/costmanagement.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/providers/Microsoft.CostManagement/reports/{reportName}/run": {


This API signature will not work. PUT on /run needs the name of the run to be created.

Updated to POST

ravbhatnagar · 2018-08-20T18:17:46Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-09-01-preview/costmanagement.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CostManagement/reports/{reportName}/run": {


same comment as above.

Updated to POST

ravbhatnagar · 2018-08-20T18:18:54Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-09-01-preview/costmanagement.json

-            "$ref": "./examples/ReportConfigDelete.json"
+            "$ref": "./examples/ReportDelete.json"
+          }
+        },


can you please move the changes of removing apis that we discussed over the call last week and adding new ones in different PRs? Lets have one PR where the removal is done.

sergey-shandar

Why are you moving from stable to preview? Usually, we don't allow this.

shalinved · 2018-08-20T18:54:02Z

@sergey-shandar - We had a couple of meeting with @ravbhatnagar on moving the APIs from stable to preview. These APIs were never meant to be released as a stable version. They were meant to unblock internal Microsoft teams integrating with us. We didn't create any SDKs, didn't publish the APIs and have already verified that all the requests we received are from internal Microsoft teams.

We understand that once the APIs are available publicly, someone could build SDKs on top of these APIs and that experience might get broken but the data we have combined with absence of any API announcements suggests there is a very slim chance of that happening.

sergey-shandar

We still need a formal approval from ARM

ravbhatnagar · 2018-08-24T00:35:07Z

Signing off from ARM side.

sergey-shandar · 2018-08-24T00:41:03Z

@shalinved please, resolve conflicts

shalinved · 2018-08-24T22:22:45Z

@sergey-shandar - Conflicts fixed after merging with upstream.

* Remove TrackedResource from Swagger spec "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource" * More updates on referring common types More updates on referring common types * Add UpdateParameters and Updateproperties * Update example * updated example * update examples Introducing new API for Azure Security Center Settings (Azure#3511) * Add new API for Azure Security Center Settings * Changed SettingsPUT API to receive parameter and not definition. * - changed settings parameter name in example and in security parameter definition - changes typo comment on settings get all example reference * changes settings to setting in Settings API * settings kind to setting kind in settings CSM API Update batch resource-manager Node.js package version to 3.1.2 (Azure#3732) IoTHub conf py (Azure#3733) Reports API moved from stable to preview version with addition of documentation of a couple of new APIs (Azure#3640) * Consumption specifications for cost insights and reporting operations * Fixed $ref for ReportConfigDelete * Silly me!! Fixed bad reference again * Fixed schema validation issues * Fixing validation errors around datetime and dynamic respones * Fixed parameters in examples * Fixed parameter name in example * Removed x-ms-odata method for POST op * Fixed ARM review comments * Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament * Merged with master again * Updated reports api documentation * Undo remove of API from stable version providing description for new introduced property isRecurringCharge fix example issues Microsoft.ResourceGraph public preview spec (Azure#3716) Add new microsoft.logic version (Azure#3683) * Copy of the source version (2016-06-01) to seed the new version (2018-07-01-preview) * Update Microsoft.Logic from 2016-06-01 to 2018-07-01-preview * Remove extra prep files, update the readme Fix Go SDK codegen for containerinstance (Azure#3735) The package-2018-06 tag was incorrecly using the 2018-04 tag. Moved Go SDK config section to its own config file. Microsoft.NetApp first version (Azure#3639) * Microsoft.NetApp first version * Addressing pullrequest comments added back billingperiod

Shalin Ved added 15 commits May 31, 2018 20:51

Consumption specifications for cost insights and reporting operations

e2fbb50

Fixed $ref for ReportConfigDelete

dcb8e98

Silly me!! Fixed bad reference again

4e8e15b

Fixed schema validation issues

e702517

Fixing validation errors around datetime and dynamic respones

4aaf2ca

Fixed parameters in examples

b51ba78

Fixed parameter name in example

5b1ce95

Removed x-ms-odata method for POST op

1d58423

Fixed ARM review comments

03c3377

Merging upstream to fork

7eea456

Merge remote-tracking branch 'upstream/master'

87b31dc

Moved reports and usage analysis from microsoft.consumption to micros…

94373fe

…oft.costmanagament

Merged with master

f2eab1a

Merged with master again

4661d6b

Updated reports api documentation

9f3607b

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR cost-management/resource-manager] Reports API moved from stable to preview version with addition of documentation of a couple of new APIs Azure/azure-sdk-for-python#3145

Merged

azuresdkci assigned sergey-shandar Aug 14, 2018

azuresdkci requested a review from sergey-shandar August 14, 2018 21:20

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR cost-management/resource-manager] Reports API moved from stable to preview version with addition of documentation of a couple of new APIs Azure/azure-sdk-for-go#2462

Closed

sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Aug 15, 2018

ravbhatnagar reviewed Aug 20, 2018

View reviewed changes

sergey-shandar suggested changes Aug 20, 2018

View reviewed changes

sergey-shandar approved these changes Aug 20, 2018

View reviewed changes

sergey-shandar requested a review from salameer August 21, 2018 19:33

Undo remove of API from stable version

41ff04d

sergey-shandar approved these changes Aug 22, 2018

View reviewed changes

sergey-shandar removed the potential-sdk-breaking-change label Aug 22, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 24, 2018

sergey-shandar removed the request for review from salameer August 24, 2018 00:54

Merged with upstream

8dceb6e

sergey-shandar merged commit 21d580e into Azure:master Aug 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reports API moved from stable to preview version with addition of documentation of a couple of new APIs #3640

Reports API moved from stable to preview version with addition of documentation of a couple of new APIs #3640

shalinved commented Aug 14, 2018 •

edited

Loading

azuresdkci commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

shalinved commented Aug 14, 2018

ravbhatnagar Aug 20, 2018

shalinved Aug 21, 2018

ravbhatnagar Aug 20, 2018

shalinved Aug 21, 2018

ravbhatnagar Aug 20, 2018

shalinved Aug 21, 2018

sergey-shandar left a comment

shalinved commented Aug 20, 2018

sergey-shandar left a comment

ravbhatnagar commented Aug 24, 2018

sergey-shandar commented Aug 24, 2018

shalinved commented Aug 24, 2018

Reports API moved from stable to preview version with addition of documentation of a couple of new APIs #3640

Reports API moved from stable to preview version with addition of documentation of a couple of new APIs #3640

Conversation

shalinved commented Aug 14, 2018 • edited Loading

PR information

Quality of Swagger

azuresdkci commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-go

shalinved commented Aug 14, 2018

ravbhatnagar Aug 20, 2018

Choose a reason for hiding this comment

shalinved Aug 21, 2018

Choose a reason for hiding this comment

ravbhatnagar Aug 20, 2018

Choose a reason for hiding this comment

shalinved Aug 21, 2018

Choose a reason for hiding this comment

ravbhatnagar Aug 20, 2018

Choose a reason for hiding this comment

shalinved Aug 21, 2018

Choose a reason for hiding this comment

sergey-shandar left a comment

Choose a reason for hiding this comment

shalinved commented Aug 20, 2018

sergey-shandar left a comment

Choose a reason for hiding this comment

ravbhatnagar commented Aug 24, 2018

sergey-shandar commented Aug 24, 2018

shalinved commented Aug 24, 2018

shalinved commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading