-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSP Migration][HybridConnectivity] TypeSpec migrated from swagger #31699
base: main
Are you sure you want to change the base?
Conversation
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…re/azure-rest-api-specs into migration/hybridconnectivity
…re/azure-rest-api-specs into migration/hybridconnectivity
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@armResourceOperations | ||
interface EndpointResources { | ||
/** | ||
* Gets the endpoint to the resource. | ||
*/ | ||
#suppress "@azure-tools/typespec-azure-core/no-openapi" "non-standard operations" | ||
@operationId("Endpoints_Get") | ||
get is ArmResourceRead< | ||
EndpointResource, | ||
Azure.ResourceManager.Foundations.ExtensionBaseParameters | ||
>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why the Endponts
-> EndpointResources
happens in convertion?
It appears Java SDK's break is caused by this pattern (same as the ServiceConfigurations
)
#32243 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK can use @clientName
to override this, so not a blocking issue for SDK.
https://github.com/Azure/azure-rest-api-specs/pull/32243/files
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.