add special handling for @bodyRoot/@body on model param's property
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
chlowell,
jhendrixMSFT and
RickWinter
as code owners
jhendrixMSFT
reviewed
Feb 5, 2025
jhendrixMSFT
reviewed
Feb 5, 2025
| action is ArmResourceActionNoContentSync< | ||
| BodyRoot, | ||
| { | ||
| @bodyRoot |
There was a problem hiding this comment.
Where can I find the docs for this decorator?
There was a problem hiding this comment.
|
@jhendrixMSFT could you review again? this bug block the hybrid connectivity's pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this problem was found in this pr: Azure/azure-rest-api-specs#31699. there is an action operation:
listIngressGatewayCredentialsforEndpointResourceresource which used@bodyRootin a model's property.previous go emitter's logic of finding parameter's corresponding http parameter is to use the direct naming comparison of the param, but this could not cover
@bodyRootor@bodyon model's property, which cause this exception.this pr just adds logic of handling first level
@bodyRootand@body. however, it is not a perfect solution, we need to refine param converting logic after we have a clear story about the relation of typespec operation api sig and sdk operation api sig.