Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft.App] targetLabel and Labels revision mode #30802

Merged
merged 39 commits into from
Oct 18, 2024

ran npx prettier

6314198
Select commit
Loading
Failed to load commit list.
Merged

[Microsoft.App] targetLabel and Labels revision mode #30802

ran npx prettier
6314198
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Sep 30, 2024 in 4m 46s

Swagger LintDiff failed

LintDiff: 53 Errors, 89 Warnings
View Azure DevOps build log for more details.

Details

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ GetCollectionResponseSchema The response in the GET collection operation 'ContainerAppsLabelHistory_ListLabelHistory' does not match the response definition in the individual GET operation 'ContainerAppsLabelHistory_GetLabelHistory' .
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L18		 RPC-Get-V1-10
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L18		 RPC-Uri-V1-05
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L19		 RPC-Get-V1-13
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L53
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L72		 RPC-Uri-V1-05
❌ ResourceNameRestriction The resource name parameter 'labelName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L72		 RPC-Uri-V1-05
❌ invalid-ref '#/definitions/labelHistory' does not exist
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L108
❌ AutoRest exception "tag":"package-preview-2024-10",
"details":"Ref '#/definitions/labelHistory' is not referencing a valid location. paths,
/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.App/containerApps/containerAppName/labelHistory/labelName,
get,
responses,
200,
schema"
❌ AutoRest exception "tag":"package-preview-2024-10",
"details":"Plugin 'full-ref-resolver' completed with some error."
❌ AutoRest exception "tag":"package-preview-2024-10",
"details":"!Error: Plugin 'full-ref-resolver' completed with some error."
❌ AutoRest exception "tag":"package-preview-2024-10",
"details":"Autorest completed with an error. If you think the error message is unclear,
or is a bug,
please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L18		 RPC-Get-V1-11
⚠️ PageableOperation Based on the response model schema, operation 'ContainerAppsLabelHistory_ListLabelHistory' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L19
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L40
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L81
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L84
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json#L101


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L99
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L100
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L131
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L198
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L227
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L270
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:activeRevisionsMode.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:transport.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:allowedOrigins.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:appProtocol.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:maxReplicas.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L310
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L336
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L348
❌ ParametersInPost customHostname is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L355
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L400
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L446
❌ PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L447
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L478
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L540
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L599
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L18
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L75
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L75
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L128
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L128
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L178
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L178
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L228
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L228
❌ ResourceNameRestriction The resource name parameter 'replicaName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L228
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L288
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L288
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L289
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L323
❌ ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L341
❌ ResourceNameRestriction The resource name parameter 'revisionName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L341
❌ ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L472
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'RevisionCollection' has extra properties ['value'].
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L510
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'RevisionCollection' has extra properties ['nextLink'].
Location: Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json#L510
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L66
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L69
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L72
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L108
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L111
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-10-02-preview/ContainerApps.json#L121
View more details on openapi-pipeline-app