-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.App] targetLabel and Labels revision mode #30802
Merged
Juliehzl
merged 39 commits into
Azure:release-app-Microsoft.App-2024-10-02-preview
from
smzeng:stacyzeng/labels-10-02
Oct 18, 2024
Merged
[Microsoft.App] targetLabel and Labels revision mode #30802
Juliehzl
merged 39 commits into
Azure:release-app-Microsoft.App-2024-10-02-preview
from
smzeng:stacyzeng/labels-10-02
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
smzeng
changed the title
copy over changes to 10-02
targetLabel and Labels revision mode
Sep 30, 2024
Tratcher
approved these changes
Sep 30, 2024
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Sep 30, 2024
jijohn14
changed the title
targetLabel and Labels revision mode
[Microsoft.App] targetLabel and Labels revision mode
Sep 30, 2024
jijohn14
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Sep 30, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Sep 30, 2024
jijohn14
requested changes
Sep 30, 2024
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json
Show resolved
Hide resolved
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/examples/LabelHistory_Get.json
Outdated
Show resolved
Hide resolved
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/examples/LabelHistory_Get.json
Outdated
Show resolved
Hide resolved
...pp/resource-manager/Microsoft.App/preview/2024-10-02-preview/examples/LabelHistory_List.json
Outdated
Show resolved
Hide resolved
specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerApps.json
Show resolved
Hide resolved
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json
Show resolved
Hide resolved
...on/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerAppsRevisions.json
Show resolved
Hide resolved
jijohn14
added
NotReadyForARMReview
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
labels
Oct 1, 2024
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Oct 1, 2024
Pl fix the errors here - https://github.com/Azure/azure-rest-api-specs/pull/30802/checks?check_run_id=30881064450 |
rkmanda
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Oct 5, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Oct 5, 2024
rkmanda
added
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
and removed
NotReadyForARMReview
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Oct 5, 2024
…ure-rest-api-specs into stacyzeng/labels-10-02
Tratcher
reviewed
Oct 15, 2024
...pp/resource-manager/Microsoft.App/preview/2024-10-02-preview/examples/LabelHistory_List.json
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Oct 15, 2024
jijohn14
approved these changes
Oct 15, 2024
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json
Outdated
Show resolved
Hide resolved
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/ContainerAppsLabelHistory.json
Show resolved
Hide resolved
...-manager/Microsoft.App/preview/2024-10-02-preview/examples/ContainerApps_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
...app/resource-manager/Microsoft.App/preview/2024-10-02-preview/examples/LabelHistory_Get.json
Outdated
Show resolved
Hide resolved
/azp run |
Commenter does not have sufficient privileges for PR 30802 in repo Azure/azure-rest-api-specs |
/azp run |
Commenter does not have sufficient privileges for PR 30802 in repo Azure/azure-rest-api-specs |
@rkmanda all the issues have been addressed this is ready for review again |
/pr RequestReview |
jijohn14
removed
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Oct 15, 2024
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Oct 15, 2024
mentat9
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Oct 17, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Oct 17, 2024
…yzeng/labels-10-02
Juliehzl
merged commit Oct 18, 2024
799421d
into
Azure:release-app-Microsoft.App-2024-10-02-preview
24 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Python-Sdk-Approved
BreakingChange-Python-Sdk-Suppression-Approved
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
add new property targetLabel and also new activeRevisionsMode labels
original PR here, but closed due to merge issues #30509
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.