Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includeDapr in traces and include keda in metrics for container app environment #29987

Conversation

michaelkira
Copy link
Contributor

@michaelkira michaelkira commented Jul 26, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Jul 26, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 26, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 26, 2024
@Juliehzl Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Aug 1, 2024
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 1, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Aug 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Aug 22, 2024
@michaelkira
Copy link
Contributor Author

/pr RequestMerge

@jijohn14 jijohn14 enabled auto-merge (squash) August 23, 2024 00:06
@jijohn14 jijohn14 merged commit 95a6733 into Azure:release-app-Microsoft.App-2024-08-02-preview Aug 23, 2024
25 of 28 checks passed
@msyyc
Copy link
Member

msyyc commented Aug 23, 2024

@jijohn14 Only SDK owner could add the SDK breaking approved label so next time please do not add it by yourself.
image

@jijohn14
Copy link
Member

@jijohn14 Only SDK owner could add the SDK breaking approved label so next time please do not add it by yourself. image

@msyyc Noted. Apologies for that. Is there any action we need to take for python sdk?
I see the sdk check is passing - https://github.com/Azure/azure-rest-api-specs/pull/29987/checks?check_run_id=29096986998

Additionally, I did it for #30231

I assumed the label is getting added from existing changes based on #30154 (comment)

@msyyc
Copy link
Member

msyyc commented Aug 23, 2024

@jijohn14 Only SDK owner could add the SDK breaking approved label so next time please do not add it by yourself. image

@msyyc Noted. Apologies for that. Is there any action we need to take for python sdk? I see the sdk check is passing - https://github.com/Azure/azure-rest-api-specs/pull/29987/checks?check_run_id=29096986998

Additionally, I did it for #30231

I assumed the label is getting added from existing changes based on #30154 (comment)

SDK owner will check the breaking items and make related action. Since you may not have much domain knowledge about SDK, adding the label by yourselves may cause unexpected breakings for SDK. That's why there is review workflow #29987 (comment)

Juliehzl added a commit that referenced this pull request Sep 24, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
jijohn14 added a commit that referenced this pull request Oct 8, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants