[Microsoft.App] add debug endpoint on replica container #29778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| ContainerAppsRevisions.json | 2024-08-02-preview(e0b4e45) | 2024-03-01(main) |
| ContainerAppsRevisions.json | 2024-08-02-preview(e0b4e45) | 2024-02-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version has a new read-only property 'debugEndpoint' in response that was not found in the old version. New: Microsoft.App/preview/2024-08-02-preview/ContainerAppsRevisions.json#L605:7 Old: Microsoft.App/preview/2024-02-02-preview/ContainerAppsRevisions.json#L605:7 |
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-preview-2024-08 | package-preview-2024-08(e0b4e45) | package-preview-2024-08(release-app-Microsoft.App-2024-08-02-preview) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=440726&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️⚠️ azure-sdk-for-python warning [Detail]
- For more instructions, please refer to the FAQ .
⚠️Warning in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. cmderr [automation_init.sh] npm notice cmderr [automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2 cmderr [automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2 cmderr [automation_init.sh] npm notice To update run: npm install -g npm@10.8.2 cmderr [automation_init.sh] npm notice command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-appcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. SDK Automation 14.0.0command ./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-appcontainers [Preview SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/appcontainers/armappcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel. command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-appcontainers [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
- For more instructions, please refer to the FAQ .
❌Code Generator Failed in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'... cmderr [initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'... cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2 cmderr [initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2 cmderr [initScript.sh] npm notice To update run: npm install -g npm@10.8.2 cmderr [initScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel. command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1203:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from 511b5fde2628fd9e91d08176a7ba70edf66fc631. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.app.DefaultTag [Preview SDK Changes]
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
bowen5
approved these changes
Jul 15, 2024
raosuhas
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
jijohn14
approved these changes
Jul 22, 2024
...on/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/examples/Replicas_List.json
Outdated
Show resolved
Hide resolved
...on/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/ContainerAppsRevisions.json
Show resolved
Hide resolved
…ase-app-Microsoft.App-2024-08-02-preview-debug-endpoint
yiliuTo
merged commit ab21dde
into
Azure:release-app-Microsoft.App-2024-08-02-preview
24 of 28 checks passed
yiliuTo
deleted the
release-app-Microsoft.App-2024-08-02-preview-debug-endpoint
branch
Juliehzl
added a commit
that referenced
this pull request
Sep 24, 2024
* Copy files from preview/2024-02-02-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-08-02-preview Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview. * Added tag for 2024-08-02-preview in readme file * Support spring cloud gateway (#29591) * support scg in 0802preview * fix lint issue --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Add scale property to java component (#29801) * add scale property for jc * swagger prettiercheck * prettier check * the prettier check has a bug * edit description * refine description --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * [Microsoft.App] add debug endpoint on replica container (#29778) * add debug endpoint on replica container * fix code style errors * add example debug endpoint * Update header and query parameter for source control (#29536) * update * fix example * fix * fix * fix * update examples * use v5 * Enable DeploymentErrors for ContainerApps (#29822) * Enable DeploymentErrors for ContainerApps * Add example * Fix format --------- Co-authored-by: layliu <layliu@microsoft.com> * Add dockerfile path argument (#30156) * Add dockerfile path argument * Fix example * Fix example * Fix linting errors * Modify example * Update sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154) * Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW * PR Feedback: Run prettier on json file for PR check-TEW * PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW * PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW" * PR Feedback: Re-ran prettier on files noted in PR Check-TEW * Removing cooldownPeriod from Jobs.json and Jobs examples-TEW * Make the header optional for source control (#30232) * Add includeDapr in traces and include keda in metrics for container app environment (#29987) * Add includeDapr in traces and include keda in metrics * pretty * Fix sessionpool name parameter location (#30231) * Fix sessionpool name parameter location * Prettier * Add job suspend resume (#30304) * add fields * add * Update Jobs.json fix runningState and add azure-asyncoperation * Update Jobs_Resume.json * Update Jobs_Suspend.json * add azure-asyncoperation * fix lintdiff * fix * fix * fix * add * reopen PR & add runningState states --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * add runningState change (#30464) Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418) * enableFips Property for workload profile * Fix description * Add default value for property * run prettier * More prettier fixes * Add system data back for billingMeter (#30627) * Fix CI check for 2024-08-02-preview (#30641) * add suppression for patch java component (#30644) Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Fix session pool error response (#30647) Co-authored-by: Zunli Hu <zuh@microsoft.com> * update --------- Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com> Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> Co-authored-by: Yi Liu <yiliu6@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: layliu <layliu@microsoft.com> Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Tara W <tawalke@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: yitaopan <yitaopan@microsoft.com> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Jitin John <jijohn@microsoft.com>
jijohn14
added a commit
that referenced
this pull request
Oct 8, 2024
* Copy files from preview/2024-02-02-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-08-02-preview Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview. * Added tag for 2024-08-02-preview in readme file * Support spring cloud gateway (#29591) * support scg in 0802preview * fix lint issue --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Add scale property to java component (#29801) * add scale property for jc * swagger prettiercheck * prettier check * the prettier check has a bug * edit description * refine description --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * [Microsoft.App] add debug endpoint on replica container (#29778) * add debug endpoint on replica container * fix code style errors * add example debug endpoint * Update header and query parameter for source control (#29536) * update * fix example * fix * fix * fix * update examples * use v5 * Enable DeploymentErrors for ContainerApps (#29822) * Enable DeploymentErrors for ContainerApps * Add example * Fix format --------- Co-authored-by: layliu <layliu@microsoft.com> * Add dockerfile path argument (#30156) * Add dockerfile path argument * Fix example * Fix example * Fix linting errors * Modify example * Update sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154) * Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW * PR Feedback: Run prettier on json file for PR check-TEW * PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW * PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW" * PR Feedback: Re-ran prettier on files noted in PR Check-TEW * Removing cooldownPeriod from Jobs.json and Jobs examples-TEW * Make the header optional for source control (#30232) * Add includeDapr in traces and include keda in metrics for container app environment (#29987) * Add includeDapr in traces and include keda in metrics * pretty * Fix sessionpool name parameter location (#30231) * Fix sessionpool name parameter location * Prettier * Add job suspend resume (#30304) * add fields * add * Update Jobs.json fix runningState and add azure-asyncoperation * Update Jobs_Resume.json * Update Jobs_Suspend.json * add azure-asyncoperation * fix lintdiff * fix * fix * fix * add * reopen PR & add runningState states --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * add runningState change (#30464) Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418) * enableFips Property for workload profile * Fix description * Add default value for property * run prettier * More prettier fixes * Add system data back for billingMeter (#30627) * Fix CI check for 2024-08-02-preview (#30641) * add suppression for patch java component (#30644) Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Fix session pool error response (#30647) Co-authored-by: Zunli Hu <zuh@microsoft.com> * Fix Swagger PrettierCheck for examples (#30674) * Copy files from preview/2024-02-02-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-08-02-preview Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview. * Added tag for 2024-08-02-preview in readme file * Support spring cloud gateway (#29591) * support scg in 0802preview * fix lint issue --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Add scale property to java component (#29801) * add scale property for jc * swagger prettiercheck * prettier check * the prettier check has a bug * edit description * refine description --------- Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * [Microsoft.App] add debug endpoint on replica container (#29778) * add debug endpoint on replica container * fix code style errors * add example debug endpoint * Update header and query parameter for source control (#29536) * update * fix example * fix * fix * fix * update examples * use v5 * Enable DeploymentErrors for ContainerApps (#29822) * Enable DeploymentErrors for ContainerApps * Add example * Fix format --------- Co-authored-by: layliu <layliu@microsoft.com> * Add dockerfile path argument (#30156) * Add dockerfile path argument * Fix example * Fix example * Fix linting errors * Modify example * Update sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154) * Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW * PR Feedback: Run prettier on json file for PR check-TEW * PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW * PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW" * PR Feedback: Re-ran prettier on files noted in PR Check-TEW * Removing cooldownPeriod from Jobs.json and Jobs examples-TEW * Make the header optional for source control (#30232) * Add includeDapr in traces and include keda in metrics for container app environment (#29987) * Add includeDapr in traces and include keda in metrics * pretty * Fix sessionpool name parameter location (#30231) * Fix sessionpool name parameter location * Prettier * Add job suspend resume (#30304) * add fields * add * Update Jobs.json fix runningState and add azure-asyncoperation * Update Jobs_Resume.json * Update Jobs_Suspend.json * add azure-asyncoperation * fix lintdiff * fix * fix * fix * add * reopen PR & add runningState states --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * add runningState change (#30464) Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418) * enableFips Property for workload profile * Fix description * Add default value for property * run prettier * More prettier fixes * Add system data back for billingMeter (#30627) * Fix CI check for 2024-08-02-preview (#30641) * add suppression for patch java component (#30644) Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> * Fix session pool error response (#30647) Co-authored-by: Zunli Hu <zuh@microsoft.com> * update --------- Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com> Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> Co-authored-by: Yi Liu <yiliu6@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: layliu <layliu@microsoft.com> Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Tara W <tawalke@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: yitaopan <yitaopan@microsoft.com> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Jitin John <jijohn@microsoft.com> * revert change (#30700) * Fix default value property error for keda properties - 08.2024 release (#30691) * Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW * PR Feedback: Run prettier on json file for PR check-TEW * PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW * PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW" * PR Feedback: Re-ran prettier on files noted in PR Check-TEW * Removing cooldownPeriod from Jobs.json and Jobs examples-TEW * Remove default for polling and cooldown to fix error-TEW * Add Identity to session pool registry (#30748) * Add Identity to session pool registry * update examples * fix --------- Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com> Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com> Co-authored-by: Yi Liu <yiliu6@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: layliu <layliu@microsoft.com> Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Tara W <tawalke@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: yitaopan <yitaopan@microsoft.com> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Jitin John <jijohn@microsoft.com> Co-authored-by: najian <jiangnan8924@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.