Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting back x-ms-azure-resource from TrackedResource definition as it is already part of the base class Resource. #2991

Merged
merged 1 commit into from
May 1, 2018

Conversation

kalyanaj
Copy link
Contributor

@kalyanaj kalyanaj commented May 1, 2018

Reverting back x-ms-azure-resource from TrackedResource definition as it is already part of the base class Resource.

As part of #2912, x-ms-azure-resource was added to TrackedResource definition for 2018-01-01 API version. Later on, as part of another commit, I added it to the 2018-05-01-preview version as well. However, it appears that this change hides the ID, Name and Type properties from the Topic object. Hence, I am reverting this commit.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

… it is already part of the base class Resource.
@AutorestCI
Copy link

AutorestCI commented May 1, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 1, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented May 1, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2698

@AutorestCI
Copy link

AutorestCI commented May 1, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@jianghaolu jianghaolu merged commit cddb8b6 into Azure:master May 1, 2018
@kalyanaj kalyanaj deleted the master branch May 1, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants