Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-ms-azure-resource for tracked resource in event grid #2912

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

jianghaolu
Copy link
Contributor

@jianghaolu jianghaolu commented Apr 20, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 20, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2440

@AutorestCI
Copy link

AutorestCI commented Apr 20, 2018

Automation for azure-libraries-for-java

A PR has been created for you:
AutorestCI/azure-libraries-for-java#99

@AutorestCI
Copy link

AutorestCI commented Apr 20, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2771

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventgrid/resource-manager/readme.md
Before the PR: Warning(s): 2 Error(s): 1
After the PR: Warning(s): 2 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Apr 20, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few questions just to make sure I fully understand this change:

  1. Just to double-check, would this be a non-breaking change / won't impact the autorest generated SDK code?
  2. Does this need to be added for types that derive from TrackedResource? ("Topic" is currently the only one)
  3. Also, would it be also to use this PR to add this change to the 2018-05-01-preview version as well?

@jianghaolu
Copy link
Contributor Author

Hi @kalyanaj
To answer your question - I don't believe this will be a breaking change but I could be wrong. The types deriving from this won't need it.

Let me sync up with the guy on my team generating the SDK. Maybe we will be okay just adding this to 2018-05-01-preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants