-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x-ms-azure-resource for tracked resource in event grid #2912
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-libraries-for-javaA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A few questions just to make sure I fully understand this change:
- Just to double-check, would this be a non-breaking change / won't impact the autorest generated SDK code?
- Does this need to be added for types that derive from TrackedResource? ("Topic" is currently the only one)
- Also, would it be also to use this PR to add this change to the 2018-05-01-preview version as well?
Hi @kalyanaj Let me sync up with the guy on my team generating the SDK. Maybe we will be okay just adding this to 2018-05-01-preview. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger