-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WRP] 2024-07-01-preview change #29861
[WRP] 2024-07-01-preview change #29861
Conversation
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
b98e068
to
1c631b5
Compare
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Generation Artifacts
|
Can you please fix the newly introduced warnings and errors in the swagger LintDiff : https://github.com/Azure/azure-rest-api-specs/pull/29861/checks?check_run_id=27575181743 |
/azp run |
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
"format": "date-time", | ||
"type": "string" | ||
}, | ||
"name": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 5458 in 2e5be0e
"name": { |
trying to align schema from here
"format": "float", | ||
"type": "number" | ||
}, | ||
"renewalPeriod": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as this comment
"format": "float", | ||
"type": "number" | ||
}, | ||
"dynamicThrottlingEnabled": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this schema is trying to align here, does changing it to enum will break the customer calling it?
"format": "float", | ||
"type": "number" | ||
}, | ||
"renewalPeriod": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what unit are values set? You should add descriptions to the properties #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below, the schema defined here is to provide the same experience as this schema:
"dynamicThrottlingEnabled": { | ||
"type": "boolean" | ||
}, | ||
"key": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 4335 in 2e5be0e
"key": { |
we provide the same schema experience based on this schema defined in cognitive service, we don't know the expected value here as we are working as a proxy in this case.
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
@@ -6353,8 +6825,15 @@ | |||
"enableDataIsolation": { | |||
"type": "boolean" | |||
}, | |||
"enableServiceSideCMKEncryption": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In place of having this enabling flags you can convert to an enum property which could have as values the types of features enabled like [ServiceSideCMKEncryption, SimplifiedCmk, SoftwareBillOfMaterials, DataIsolation]. In this way you dont need to add new properties in a new version #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will sync with my team to create a property like you suggest in next version to avoid this in the future, thanks for the good suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task 3360389: Create a feature property bag to avoid more featureflag in workspace properties.
created work item here to track.
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
…ngServices-2024-07-01-preview' into user/zhili/update-07-01-preview
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
c61c6ff
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.