[WRP] 2024-07-01-preview change #29861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
ZhidaLiu
force-pushed
the
user/zhili/update-07-01-preview
branch
from
b98e068
to
1c631b5
Compare
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Generation Artifacts
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
|
Can you please fix the newly introduced warnings and errors in the swagger LintDiff : https://github.com/Azure/azure-rest-api-specs/pull/29861/checks?check_run_id=27575181743 |
raosuhas
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
/azp run |
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
| "format": "date-time", | ||
| "type": "string" | ||
| }, | ||
| "name": { |
There was a problem hiding this comment.
trying to align schema from here
| "format": "float", | ||
| "type": "number" | ||
| }, | ||
| "renewalPeriod": { |
There was a problem hiding this comment.
Same as this comment
| "format": "float", | ||
| "type": "number" | ||
| }, | ||
| "dynamicThrottlingEnabled": { |
There was a problem hiding this comment.
this schema is trying to align here, does changing it to enum will break the customer calling it?
| "format": "float", | ||
| "type": "number" | ||
| }, | ||
| "renewalPeriod": { |
There was a problem hiding this comment.
In what unit are values set? You should add descriptions to the properties #Resolved
There was a problem hiding this comment.
Same as below, the schema defined here is to provide the same experience as this schema:
| "dynamicThrottlingEnabled": { | ||
| "type": "boolean" | ||
| }, | ||
| "key": { |
There was a problem hiding this comment.
we provide the same schema experience based on this schema defined in cognitive service, we don't know the expected value here as we are working as a proxy in this case.
...source-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceRP.json
Show resolved
Hide resolved
| @@ -6353,8 +6825,15 @@ | |||
| "enableDataIsolation": { | |||
| "type": "boolean" | |||
| }, | |||
| "enableServiceSideCMKEncryption": { | |||
There was a problem hiding this comment.
In place of having this enabling flags you can convert to an enum property which could have as values the types of features enabled like [ServiceSideCMKEncryption, SimplifiedCmk, SoftwareBillOfMaterials, DataIsolation]. In this way you dont need to add new properties in a new version #Resolved
There was a problem hiding this comment.
I will sync with my team to create a property like you suggest in next version to avoid this in the future, thanks for the good suggestion.
There was a problem hiding this comment.
Task 3360389: Create a feature property bag to avoid more featureflag in workspace properties.
created work item here to track.
razvanbadea-msft
added
the
ARMChangesRequested
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
razvanbadea-msft
removed
the
WaitForARMFeedback
…ngServices-2024-07-01-preview' into user/zhili/update-07-01-preview
ZhidaLiu
removed
the
ARMChangesRequested
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
razvanbadea-msft
added
Approved-Suppression
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
ragovada
approved these changes
Jul 23, 2024
ZhidaLiu
merged commit c61c6ff
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
24 of 28 checks passed
razvanbadea-msft
pushed a commit
that referenced
this pull request
Jul 26, 2024
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
hmmorales
pushed a commit
that referenced
this pull request
Jul 31, 2024
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.