Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview #29657

Conversation

theodoreschen
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Copy link

openapi-pipeline-app bot commented Jul 1, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jul 1, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.12) new version base version
registries.json 2024-07-01-preview(0ed8e06) 2024-04-01(main)
registries.json 2024-07-01-preview(0ed8e06) 2024-04-01-preview(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-07 package-preview-2024-07(0ed8e06) package-preview-2024-07(release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L103
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L247
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L275
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L275
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L24
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L34
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L66
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L69
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L72
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L79
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L114
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L117
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L130
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L182
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L185
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L191
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L198
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L231
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L234
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L240
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L256
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L289
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L292
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L298
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L314
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L359
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L362
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json#L368
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 1, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
  • Azure.ResourceManager.MachineLearning [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/machinelearning/armmachinelearning [Preview SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-machinelearningservices [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-machinelearning [Preview SDK Changes] Breaking Change Detected
    Only showing 120 items here. Refer to log for details.
    info	[Changelog] #### `models.KubernetesOnlineDeployment` was modified
    info	[Changelog]
    info	[Changelog] * `withDataCollector(models.DataCollector)` was added
    info	[Changelog] * `provisioningState()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `endpointComputeType()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.AccountKeyDatastoreSecrets` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `secretsType()` was added
    info	[Changelog]
    info	[Changelog] #### `models.ServicePrincipalDatastoreSecrets` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `secretsType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.OnlineEndpointProperties` was modified
    info	[Changelog]
    info	[Changelog] * `withMirrorTraffic(java.util.Map)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `scoringUri()` was added
    info	[Changelog] * `mirrorTraffic()` was added
    info	[Changelog] * `swaggerUri()` was added
    info	[Changelog]
    info	[Changelog] #### `models.CustomSeasonality` was modified
    info	[Changelog]
    info	[Changelog] * `mode()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ResourceId` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.RecurrenceTrigger` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `triggerType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.FqdnEndpointDetail` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComputeInstanceLastOperation` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ForecastingSettings` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.EnvironmentContainerResourceArmPaginatedResult` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.JobBaseProperties` was modified
    info	[Changelog]
    info	[Changelog] * `notificationSetting()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `withNotificationSetting(models.NotificationSetting)` was added
    info	[Changelog] * `jobType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.PyTorch` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `distributionType()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.UserAssignedIdentity` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.DataLakeAnalyticsSchemaProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComponentVersionProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `provisioningState()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.SamplingAlgorithm` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `samplingAlgorithmType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.PatAuthTypeWorkspaceConnectionProperties` was modified
    info	[Changelog]
    info	[Changelog] * `group()` was added
    info	[Changelog] * `withMetadata(java.util.Map)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `withSharedUserList(java.util.List)` was added
    info	[Changelog] * `withIsSharedToAll(java.lang.Boolean)` was added
    info	[Changelog] * `withExpiryTime(java.time.OffsetDateTime)` was added
    info	[Changelog] * `authType()` was added
    info	[Changelog] * `createdByWorkspaceArmId()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComputeSchedules` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog]
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-machinelearning [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 2aa6cc9214cce410e1ec519b342cbfcc14a33395. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.machinelearningservices.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 1, 2024

@chaoyu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@chaoyu-msft chaoyu-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 3, 2024
@madhura-np madhura-np added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2024
theodorechen-msft and others added 2 commits July 15, 2024 15:10
…ngServices-2024-07-01-preview' into release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
@raosuhas raosuhas removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 16, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2024
…ngServices-2024-07-01-preview' into release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
@raosuhas
Copy link

AS discussed in office hours this is an acceptable use of uuid. Please add a suppression for this and restart ARM review by removing the tags

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 16, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2024
@theodoreschen theodoreschen added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChange-Python-Sdk BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-LintDiff suppressions for LintDiff errors labels Jul 18, 2024
@raosuhas
Copy link

Could you please add a suppressions for the failing Lint Validation ? Is a valid usage of the UUID since it is the AAD objectid

Is there an example of how to suppress Lint Validations? The docs only seem to explain how to suppress SDK breaking changes

This is all explained if you used the correct template for the control plane API. For future reference , please do not skip that step above.

Pasting the relevant section here for now :

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 18, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2024
@theodoreschen theodoreschen removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk BreakingChange-LintDiff suppressions for LintDiff errors labels Jul 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 19, 2024
@razvanbadea-msft razvanbadea-msft added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jul 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2024
@theodoreschen theodoreschen enabled auto-merge (squash) July 22, 2024 13:40
@theodoreschen
Copy link
Contributor Author

/pr RequestMerge

@razvanbadea-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@theodoreschen theodoreschen merged commit a43edac into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview Jul 22, 2024
25 of 29 checks passed
razvanbadea-msft pushed a commit that referenced this pull request Jul 26, 2024
…024 07 01 preview (#29503)

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-07-01-preview

Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview.

* Added tag for 2024-07-01-preview in readme file

* Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519)

* add expirable secrets

* examples + spelling

* prettier + spell check

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* Fix Prettier errors (#29523)

* Fix Prettier errors

* Add pre-approved supressions

* fix formatting

* Add finetuning job with maap contracts. (#29638)

* Add finetuning job with maap contracts.

* prettier

* adding exceptions.

* add reference to examples.

* prettier

* Fix gate.

* Fixed the comment, added "FineTuning" in JobType.

* Fixed comment.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* WRP 2024-07-01-preview swagger change (#29729)

* sync with previous preview

* Update exmaples

* Update more example and readme

* Update suppression from previous preview

* Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657)

* tc: adding managedResrouceGroupSettings to 2024-07-01-preview

* tc: adding missing definitions

* tc: adding more definitions

* tc: applying changes based on comments

* tc: adding SDK suppression for UUID formatting

* tc: removing the suppression - because I don't think this is right

* tc: adding guid suppression - not sure if it's the correct format

* tc: adding suppressions.yaml

* tc: put suppression in readme file

---------

Co-authored-by: Theodore Chen <theodorechen@microsoft.com>

* [WRP] 2024-07-01-preview change (#29861)

* Add changes for 07-01-preview

* add missing properties

* rename example

* rename example

* Update Schema

* Update type dicriminator

* Fix errors

* Error fix

* Update example and readme

* run prettier

* Rename to fix some schema name conflict

* Update suppressions

* Update comment feedbacks

* run prettier

---------

Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com>
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Theodore Chen <theodoreschen@gmail.com>
Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
hmmorales pushed a commit that referenced this pull request Jul 31, 2024
…024 07 01 preview (#29503)

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-07-01-preview

Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview.

* Added tag for 2024-07-01-preview in readme file

* Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519)

* add expirable secrets

* examples + spelling

* prettier + spell check

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* Fix Prettier errors (#29523)

* Fix Prettier errors

* Add pre-approved supressions

* fix formatting

* Add finetuning job with maap contracts. (#29638)

* Add finetuning job with maap contracts.

* prettier

* adding exceptions.

* add reference to examples.

* prettier

* Fix gate.

* Fixed the comment, added "FineTuning" in JobType.

* Fixed comment.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* WRP 2024-07-01-preview swagger change (#29729)

* sync with previous preview

* Update exmaples

* Update more example and readme

* Update suppression from previous preview

* Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657)

* tc: adding managedResrouceGroupSettings to 2024-07-01-preview

* tc: adding missing definitions

* tc: adding more definitions

* tc: applying changes based on comments

* tc: adding SDK suppression for UUID formatting

* tc: removing the suppression - because I don't think this is right

* tc: adding guid suppression - not sure if it's the correct format

* tc: adding suppressions.yaml

* tc: put suppression in readme file

---------

Co-authored-by: Theodore Chen <theodorechen@microsoft.com>

* [WRP] 2024-07-01-preview change (#29861)

* Add changes for 07-01-preview

* add missing properties

* rename example

* rename example

* Update Schema

* Update type dicriminator

* Fix errors

* Error fix

* Update example and readme

* run prettier

* Rename to fix some schema name conflict

* Update suppressions

* Update comment feedbacks

* run prettier

---------

Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com>
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Theodore Chen <theodoreschen@gmail.com>
Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants