`datafactory`: unique names for the enum `type` for discriminated types #28319

stephybun · 2024-03-19T11:31:15Z

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
The enum type for discriminated types has several differing definitions across the service. This PR gives the enum type for discriminated types a unique name.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

openapi-workflow-bot · 2024-03-19T11:31:18Z

Hi @stephybun, this service has enabled ShiftLeft Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it is intentional or reject it if it is not expected. Normally, all the specification or example changes should start with PR created in ADO.

You can refer to ShiftLeft Toolset Introduction for details.

Please contact service focal contacts or ShiftLeft Toolset Support Channel if need further help.

openapi-pipeline-app · 2024-03-19T11:31:19Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

openapi-pipeline-app · 2024-03-19T11:31:19Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/f3243e200a6bba8dfbb29ab6710eeee80660abf1/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json", "details":"incompatible properties : properties "

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.0)	new version	base version
package-2018-06	package-2018-06(f3243e2)	package-2018-06(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L56
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L57
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L352
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:type. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L437
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L457
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L496
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L696
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L755
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L797
`❌` ConsistentPatchProperties	The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
`❌` ConsistentPatchProperties	The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L950
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L981
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1175
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1181
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1188
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1221
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1227
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1418
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1504
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1510
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1813
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1875
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1917
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2018
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2080
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2122
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2223
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2285
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2327

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 83 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1168:22 ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1217:22 ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1497:22 ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L46:35
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L56:36
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L50:47
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L51:45
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L60:47
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L124:31
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L134:32
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L128:43
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L129:41
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L138:43
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L112:31
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L122:32
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L116:43
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L117:41
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L126:43
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L47:31
`❌` INVALID_TYPE	Expected type object but found type array Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L57:32
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L51:43
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L52:41
`❌` INVALID_TYPE	Expected type object but found type string Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L61:43
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5737:31 ExampleUrl: stable/2018-06-01/examples/Pipelines_CreateRun.json#L8:19
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6670:31 ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L48:28
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6670:31 ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L69:28

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-19T11:31:20Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m

❌Azure.ResourceManager.DataFactory [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-datafactory [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ManagedIdentityCredential no longer has parameter resource_id

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Model ManagedIdentityCredential no longer has parameter resource_id

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh]   Average Speed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0    0     0  1036k      0 --:--:-- --:--:-- --:--:-- 1036k
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[init.sh] npm notice
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ################################## 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-datafactory [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/datafactory/armdatafactory [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
info	[Changelog] - Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
info	[Changelog] - Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
info	[Changelog] - Type of `DatasetReference.Type` has been changed from `*DatasetReferenceType` to `*DataSetReferenceType`
info	[Changelog] - Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
info	[Changelog] - Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
info	[Changelog] - Enum `DatasetReferenceType` has been removed
info	[Changelog] - Struct `ManagedIdentityCredentialResource` has been removed
info	[Changelog] - Struct `ManagedIdentityTypeProperties` has been removed
info	[Changelog] - Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
info	[Changelog] - Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
info	[Changelog] - Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `DataSetReferenceType` with values `DataSetReferenceTypeDatasetReference`
info	[Changelog] - New struct `CredentialResource`
info	[Changelog] - New anonymous field `CredentialResource` in struct `CredentialOperationsClientCreateOrUpdateResponse`
info	[Changelog] - New anonymous field `CredentialResource` in struct `CredentialOperationsClientGetResponse`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 6 additive change(s).

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Enum `DatasetReferenceType` has been removed
- Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
- Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
- Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
- Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
- Struct `ManagedIdentityCredentialResource` has been removed
- Struct `ManagedIdentityTypeProperties` has been removed
- Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
- Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
- Type of `DatasetReference.Type` has been changed from `*DatasetReferenceType` to `*DataSetReferenceType`
- Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
- Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-datafactory [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-datafactory-15.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ServicePrincipalCredentialResource
info	[Changelog]   - Added Type Alias DataSetReferenceType
info	[Changelog]   - Added Type Alias ExpressionType
info	[Changelog]   - Added Type Alias IntegrationRuntimeReferenceType
info	[Changelog]   - Added Type Alias PipelineReferenceType
info	[Changelog]   - Added Enum KnownDataSetReferenceType
info	[Changelog]   - Added Enum KnownExpressionType
info	[Changelog]   - Added Enum KnownIntegrationRuntimeReferenceType
info	[Changelog]   - Added Enum KnownPipelineReferenceType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation CredentialOperations.createOrUpdate has a new signature
info	[Changelog]   - Interface ManagedIdentityCredential no longer has parameter resourceId
info	[Changelog]   - Type of parameter headers of interface AzureFunctionActivity is changed from {
info	[Changelog]         [propertyName: string]: string;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
info	[Changelog]   - Type of parameter type of interface DatasetReference is changed from "DatasetReference" to DataSetReferenceType
info	[Changelog]   - Type of parameter type of interface Expression is changed from "Expression" to ExpressionType
info	[Changelog]   - Type of parameter type of interface IntegrationRuntimeReference is changed from "IntegrationRuntimeReference" to IntegrationRuntimeReferenceType
info	[Changelog]   - Type of parameter type of interface PipelineReference is changed from "PipelineReference" to PipelineReferenceType
info	[Changelog]   - Type of parameter headers of interface WebActivity is changed from {
info	[Changelog]         [propertyName: string]: string;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter headers of interface WebHookActivity is changed from {
info	[Changelog]         [propertyName: string]: string;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Interface ManagedIdentityCredential no longer has parameter resourceId
- Operation CredentialOperations.createOrUpdate has a new signature
- Type of parameter headers of interface AzureFunctionActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
- Type of parameter headers of interface WebActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
- Type of parameter headers of interface WebHookActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
- Type of parameter type of interface DatasetReference is changed from "DatasetReference" to DataSetReferenceType
- Type of parameter type of interface Expression is changed from "Expression" to ExpressionType
- Type of parameter type of interface IntegrationRuntimeReference is changed from "IntegrationRuntimeReference" to IntegrationRuntimeReferenceType
- Type of parameter type of interface PipelineReference is changed from "PipelineReference" to PipelineReferenceType
- Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

❌datafactory/resource-manager [View full logs] [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from e8de0c5e757bd0522ccff64e182c1769c640bf63. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.datafactory.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-19T11:31:21Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/datafactory/armdatafactory	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-datafactory	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-datafactory	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger	Microsoft.DataFactory	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

microsoft-github-policy-service · 2024-03-19T11:31:29Z

Thank you for your contribution stephybun! We will review the pull request and get back to you soon.

ms-henglu · 2024-03-25T07:30:29Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          ],
+          "x-ms-enum": {
+            "name": "ExpressionType",
+            "modelAsString": false


Please use modelAsString: true, which could allow more values to add to this enum.

Thanks, updated

openapi-workflow-bot · 2024-03-25T07:30:40Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

wuxu92 · 2024-05-09T07:44:01Z

Does this PR conflict with #23013? It appears that both PRs address the same issue.

add unique enum names for various constants

4f224ae

stephybun requested review from Frey-Wang, zhangyd2015 and davidzhaoyue as code owners March 19, 2024 11:31

openapi-workflow-bot bot added ShiftLeftViolation DoNotMerge <valid label in PR review process> use to hold merge after approval labels Mar 19, 2024

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 19, 2024

azure-sdk mentioned this pull request Mar 19, 2024

[AutoPR sdk/resourcemanager/datafactory/armdatafactory] datafactory: unique names for the enum type for discriminated types azure-sdk/azure-sdk-for-go#9353

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 19, 2024

azure-sdk mentioned this pull request Mar 19, 2024

[AutoPR datafactory/resource-manager] datafactory: unique names for the enum type for discriminated types azure-sdk/azure-resource-manager-schemas#4469

Draft

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 19, 2024

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Mar 19, 2024

azure-sdk mentioned this pull request Mar 19, 2024

[AutoPR track2_azure-mgmt-datafactory] datafactory: unique names for the enum type for discriminated types azure-sdk/azure-sdk-for-python#6607

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Mar 19, 2024

stephybun mentioned this pull request Mar 19, 2024

DataFactory @ 2018-06-01 duplicate type constant defined in-line on nested models hashicorp/pandora#3725

Closed

ms-henglu reviewed Mar 25, 2024

View reviewed changes

ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 25, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 25, 2024

update modelAsString to true

5bd125b

stephybun requested a review from ms-henglu March 26, 2024 11:54

azure-sdk added BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk and removed CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-BreakingChange-Python labels Mar 26, 2024

Merge branch 'main' into f/unique-enum-names

f3243e2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`datafactory`: unique names for the enum `type` for discriminated types #28319

`datafactory`: unique names for the enum `type` for discriminated types #28319

stephybun commented Mar 19, 2024

openapi-workflow-bot bot commented Mar 19, 2024

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

microsoft-github-policy-service bot commented Mar 19, 2024

ms-henglu Mar 25, 2024

stephybun Mar 26, 2024

openapi-workflow-bot bot commented Mar 25, 2024

wuxu92 commented May 9, 2024

datafactory: unique names for the enum type for discriminated types #28319

Are you sure you want to change the base?

datafactory: unique names for the enum type for discriminated types #28319

Conversation

stephybun commented Mar 19, 2024

Purpose of this PR

Due diligence checklist

openapi-workflow-bot bot commented Mar 19, 2024

openapi-pipeline-app bot commented Mar 19, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Mar 19, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 19, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Mar 19, 2024 • edited Loading

Generated ApiView

microsoft-github-policy-service bot commented Mar 19, 2024

ms-henglu Mar 25, 2024

Choose a reason for hiding this comment

stephybun Mar 26, 2024

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Mar 25, 2024

wuxu92 commented May 9, 2024

`datafactory`: unique names for the enum `type` for discriminated types #28319

`datafactory`: unique names for the enum `type` for discriminated types #28319

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2024 •

edited

Loading