Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datafactory: making the References actual Discriminated Types rather than documenting around it #23013

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tombuildsstuff
Copy link
Contributor

These two types being defined with the same constant name causes flapping on our side where the constant is pulled out with differing values: https://github.com/hashicorp/pandora/pull/2210/files#diff-39360c196a766e2866c7638d98b4bd115acaf568d065d9763a2c3f4d74440d5dL9-R10

Since there's a type field these are discriminated types and should be annotated as such, so this PR makes that change which fixes this issue.

@openapi-workflow-bot
Copy link

Hi @tombuildsstuff, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to Service API Toolset Introduction for details.
  • Please contact service focal contacts or Service API Toolset Support Channel if need further help.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 10, 2023

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/afdb5bca2b32b05451e1f1c4d5fc6a399a9b320b/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json",
    "details":"incompatible properties : properties\n definitions/ManagedIdentityCredentialResource/properties/properties\n at file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7683:8\n definitions/CredentialResource/properties/properties\n at file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7983:8"
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    Compared specs (v2.2.2) new version base version
    package-2018-06 package-2018-06(afdb5bc) package-2018-06(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L56
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L57
    PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L352
    PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L437
    GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L457
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L496
    PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L696
    GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L755
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L797
    ConsistentPatchProperties The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
    ConsistentPatchProperties The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
    XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L950
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L981
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1175
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1181
    PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1188
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1221
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1227
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1418
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1504
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1510
    PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1813
    GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1875
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1917
    PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2018
    GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2080
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2122
    PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2223
    GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2285
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2327
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 83 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1168:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1217:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1497:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L46:35
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L56:36
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L50:47
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L51:45
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L60:47
    INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L124:31
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L134:32
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L128:43
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L129:41
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L138:43
    INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L112:31
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L122:32
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L116:43
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L117:41
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L126:43
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L47:31
    INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L57:32
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L51:43
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L52:41
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L61:43
    INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5740:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_CreateRun.json#L8:19
    INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6665:31
    ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L48:28
    INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6665:31
    ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L69:28
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 10, 2023
    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 10, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 10, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
      cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
      cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
      cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
    • Azure.ResourceManager.DataFactory [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[automation_init.sh] npm notice
      cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
      cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
      cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
      cmderr	[automation_init.sh] npm notice
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-datafactory [Preview SDK Changes]
      • azure_mgmt_datafactory-1.0.0-py3-none-any.whl
      • azure-mgmt-datafactory-1.0.0.zip
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter application_intent
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter authentication_type
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter command_timeout
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter connect_retry_count
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter connect_retry_interval
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter connect_timeout
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter database
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter encrypt
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter failover_partner
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter host_name_in_certificate
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter integrated_security
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter load_balance_timeout
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter max_pool_size
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter min_pool_size
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter multi_subnet_failover
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter multiple_active_result_sets
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter packet_size
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter pooling
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter server
      info	[Changelog]   - Model AmazonRdsForSqlServerLinkedService has a new parameter trust_server_certificate
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter application_intent
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter authentication_type
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter command_timeout
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter connect_retry_count
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter connect_retry_interval
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter connect_timeout
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter database
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter encrypt
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter failover_partner
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter host_name_in_certificate
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter integrated_security
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter load_balance_timeout
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter max_pool_size
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter min_pool_size
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter multi_subnet_failover
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter multiple_active_result_sets
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter packet_size
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter pooling
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter server
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter service_principal_credential
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter service_principal_credential_type
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter trust_server_certificate
      info	[Changelog]   - Model AzureSqlDWLinkedService has a new parameter user_name
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter application_intent
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter authentication_type
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter command_timeout
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter connect_retry_count
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter connect_retry_interval
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter connect_timeout
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter database
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter encrypt
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter failover_partner
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter host_name_in_certificate
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter integrated_security
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter load_balance_timeout
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter max_pool_size
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter min_pool_size
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter multi_subnet_failover
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter multiple_active_result_sets
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter packet_size
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter pooling
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter server
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter service_principal_credential
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter service_principal_credential_type
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter trust_server_certificate
      info	[Changelog]   - Model AzureSqlDatabaseLinkedService has a new parameter user_name
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter application_intent
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter authentication_type
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter command_timeout
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter connect_retry_count
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter connect_retry_interval
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter connect_timeout
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter database
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter encrypt
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter failover_partner
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter host_name_in_certificate
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter integrated_security
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter load_balance_timeout
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter max_pool_size
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter min_pool_size
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter multi_subnet_failover
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter multiple_active_result_sets
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter packet_size
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter pooling
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter server
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter service_principal_credential
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter service_principal_credential_type
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter trust_server_certificate
      info	[Changelog]   - Model AzureSqlMILinkedService has a new parameter user_name
      info	[Changelog]   - Model ManagedIdentityCredential has a new parameter resource_id
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter application_intent
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter authentication_type
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter command_timeout
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter connect_retry_count
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter connect_retry_interval
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter connect_timeout
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter database
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter encrypt
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter failover_partner
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter host_name_in_certificate
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter integrated_security
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter load_balance_timeout
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter max_pool_size
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter min_pool_size
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter multi_subnet_failover
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter multiple_active_result_sets
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter packet_size
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter pooling
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter server
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter trust_server_certificate
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-datafactory [Preview SDK Changes]
      • pom.xml
      • azure-resourcemanager-datafactory-1.0.0-beta.29.jar
      • azure-resourcemanager-datafactory-1.0.0-beta.29-sources.jar
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datafactory/armdatafactory [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `DatasetReference.Type` has been changed from `*DatasetReferenceType` to `*string`
      info	[Changelog] - Type of `IntegrationRuntimeReference.Type` has been changed from `*IntegrationRuntimeReferenceType` to `*string`
      info	[Changelog] - Type of `LinkedServiceReference.Type` has been changed from `*LinkedServiceReferenceType` to `*string`
      info	[Changelog] - Type of `PipelineReference.Type` has been changed from `*PipelineReferenceType` to `*string`
      info	[Changelog] - Enum `DatasetReferenceType` has been removed
      info	[Changelog] - Enum `IntegrationRuntimeReferenceType` has been removed
      info	[Changelog] - Enum `LinkedServiceReferenceType` has been removed
      info	[Changelog] - Enum `PipelineReferenceType` has been removed
      info	[Changelog] - Enum `ScriptType` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - Type of `ScriptActivityScriptBlock.Type` has been changed from `*ScriptType` to `any`
      info	[Changelog] - New enum type `AmazonRdsForSQLAuthenticationType` with values `AmazonRdsForSQLAuthenticationTypeSQL`, `AmazonRdsForSQLAuthenticationTypeWindows`
      info	[Changelog] - New enum type `AzureSQLDWAuthenticationType` with values `AzureSQLDWAuthenticationTypeSQL`, `AzureSQLDWAuthenticationTypeServicePrincipal`, `AzureSQLDWAuthenticationTypeSystemAssignedManagedIdentity`, `AzureSQLDWAuthenticationTypeUserAssignedManagedIdentity`
      info	[Changelog] - New enum type `AzureSQLDatabaseAuthenticationType` with values `AzureSQLDatabaseAuthenticationTypeSQL`, `AzureSQLDatabaseAuthenticationTypeServicePrincipal`, `AzureSQLDatabaseAuthenticationTypeSystemAssignedManagedIdentity`, `AzureSQLDatabaseAuthenticationTypeUserAssignedManagedIdentity`
      info	[Changelog] - New enum type `AzureSQLMIAuthenticationType` with values `AzureSQLMIAuthenticationTypeSQL`, `AzureSQLMIAuthenticationTypeServicePrincipal`, `AzureSQLMIAuthenticationTypeSystemAssignedManagedIdentity`, `AzureSQLMIAuthenticationTypeUserAssignedManagedIdentity`
      info	[Changelog] - New enum type `SQLServerAuthenticationType` with values `SQLServerAuthenticationTypeSQL`, `SQLServerAuthenticationTypeWindows`
      info	[Changelog] - New function `*DatasetReference.GetReference() *Reference`
      info	[Changelog] - New function `*IntegrationRuntimeReference.GetReference() *Reference`
      info	[Changelog] - New function `*LinkedServiceReference.GetReference() *Reference`
      info	[Changelog] - New function `*PipelineReference.GetReference() *Reference`
      info	[Changelog] - New function `*Reference.GetReference() *Reference`
      info	[Changelog] - New struct `ManagedIdentityTypeProperties`
      info	[Changelog] - New field `ApplicationIntent`, `AuthenticationType`, `CommandTimeout`, `ConnectRetryCount`, `ConnectRetryInterval`, `ConnectTimeout`, `Database`, `Encrypt`, `FailoverPartner`, `HostNameInCertificate`, `IntegratedSecurity`, `LoadBalanceTimeout`, `MaxPoolSize`, `MinPoolSize`, `MultiSubnetFailover`, `MultipleActiveResultSets`, `PacketSize`, `Pooling`, `Server`, `TrustServerCertificate` in struct `AmazonRdsForSQLServerLinkedServiceTypeProperties`
      info	[Changelog] - New field `ApplicationIntent`, `AuthenticationType`, `CommandTimeout`, `ConnectRetryCount`, `ConnectRetryInterval`, `ConnectTimeout`, `Database`, `Encrypt`, `FailoverPartner`, `HostNameInCertificate`, `IntegratedSecurity`, `LoadBalanceTimeout`, `MaxPoolSize`, `MinPoolSize`, `MultiSubnetFailover`, `MultipleActiveResultSets`, `PacketSize`, `Pooling`, `Server`, `ServicePrincipalCredential`, `ServicePrincipalCredentialType`, `TrustServerCertificate`, `UserName` in struct `AzureSQLDWLinkedServiceTypeProperties`
      info	[Changelog] - New field `ApplicationIntent`, `AuthenticationType`, `CommandTimeout`, `ConnectRetryCount`, `ConnectRetryInterval`, `ConnectTimeout`, `Database`, `Encrypt`, `FailoverPartner`, `HostNameInCertificate`, `IntegratedSecurity`, `LoadBalanceTimeout`, `MaxPoolSize`, `MinPoolSize`, `MultiSubnetFailover`, `MultipleActiveResultSets`, `PacketSize`, `Pooling`, `Server`, `ServicePrincipalCredential`, `ServicePrincipalCredentialType`, `TrustServerCertificate`, `UserName` in struct `AzureSQLDatabaseLinkedServiceTypeProperties`
      info	[Changelog] - New field `ApplicationIntent`, `AuthenticationType`, `CommandTimeout`, `ConnectRetryCount`, `ConnectRetryInterval`, `ConnectTimeout`, `Database`, `Encrypt`, `FailoverPartner`, `HostNameInCertificate`, `IntegratedSecurity`, `LoadBalanceTimeout`, `MaxPoolSize`, `MinPoolSize`, `MultiSubnetFailover`, `MultipleActiveResultSets`, `PacketSize`, `Pooling`, `Server`, `ServicePrincipalCredential`, `ServicePrincipalCredentialType`, `TrustServerCertificate`, `UserName` in struct `AzureSQLMILinkedServiceTypeProperties`
      info	[Changelog] - New field `TypeProperties` in struct `ManagedIdentityCredential`
      info	[Changelog] - New field `ApplicationIntent`, `AuthenticationType`, `CommandTimeout`, `ConnectRetryCount`, `ConnectRetryInterval`, `ConnectTimeout`, `Database`, `Encrypt`, `FailoverPartner`, `HostNameInCertificate`, `IntegratedSecurity`, `LoadBalanceTimeout`, `MaxPoolSize`, `MinPoolSize`, `MultiSubnetFailover`, `MultipleActiveResultSets`, `PacketSize`, `Pooling`, `Server`, `TrustServerCertificate` in struct `SQLServerLinkedServiceTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 10 breaking change(s), 35 additive change(s).
      Present SDK breaking changes suppressions
      Enum `ScriptType` has been removed
      Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
      Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
      Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
      Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
      Struct `ManagedIdentityCredentialResource` has been removed
      Struct `ManagedIdentityTypeProperties` has been removed
      Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
      Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Absent SDK breaking changes suppressions
      - Enum `DatasetReferenceType` has been removed
      - Enum `IntegrationRuntimeReferenceType` has been removed
      - Enum `LinkedServiceReferenceType` has been removed
      - Enum `PipelineReferenceType` has been removed
      - Type of `DatasetReference.Type` has been changed from `*DatasetReferenceType` to `*string`
      - Type of `IntegrationRuntimeReference.Type` has been changed from `*IntegrationRuntimeReferenceType` to `*string`
      - Type of `LinkedServiceReference.Type` has been changed from `*LinkedServiceReferenceType` to `*string`
      - Type of `PipelineReference.Type` has been changed from `*PipelineReferenceType` to `*string`
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [Preview SDK Changes] Breaking Change Detected
      • azure-arm-datafactory-16.0.0.tgz
      Only showing 120 items here. Refer to log for details.
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter database
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter userName
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter userName
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter userName
      info	[Changelog]   - Interface ManagedIdentityCredential has a new optional parameter resourceId
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter database
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter server
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Added Enum KnownAmazonRdsForSqlAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlDatabaseAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlDWAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlMIAuthenticationType
      info	[Changelog]   - Added Enum KnownSqlServerAuthenticationType
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Type of parameter type of interface LinkedServiceReference is changed from Type to "LinkedServiceReference"
      info	[Changelog]   - Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      info	[Changelog]   - Removed Enum KnownType
      Present SDK breaking changes suppressions
      Interface ManagedIdentityCredential no longer has parameter resourceId
      Operation CredentialOperations.createOrUpdate has a new signature
      Type of parameter headers of interface AzureFunctionActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebHookActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
      Absent SDK breaking changes suppressions
      - Removed Enum KnownType
      - Type of parameter type of interface LinkedServiceReference is changed from Type to "LinkedServiceReference"
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Code Generator Failed in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
      cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
      cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
      cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
      cmderr	[initScript.sh]  notice
      cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
      cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
      cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.7.0` to update!
      cmderr	[initScript.sh] npm notice
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
      cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
      cmderr	[generateScript.sh]            ^
      cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
      cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
      cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
      cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
      cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
      cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
      cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
      cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
      cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
      cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
      cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
      cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
      cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
      cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
      warn	Skip package processing as generation is failed
      error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
    ️⚠️ azure-powershell warning [Detail]
    • ⚠️Warning in generating from 649ddbaa5451ea667c4a0a52d4d232279d75605a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ⚠️Az.datafactory.DefaultTag [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost
    Copy link

    ghost commented Mar 10, 2023

    Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 10, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datafactory/armdatafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-datafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-datafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Swagger Microsoft.DataFactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @ArcturusZhang ArcturusZhang removed their assignment Jun 28, 2023
    @ArcturusZhang
    Copy link
    Member

    This PR is now pending on the ADF service team's review.

    @wuxu92 considering you are a member of Azure organization, could you contact those persons internally to speed things up?

    @tombuildsstuff
    Copy link
    Contributor Author

    Any update here @ArcturusZhang @wuxu92 @rkmanda @AzureRestAPISpecReview?

    Copy link
    Member

    @Frey-Wang Frey-Wang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This should be extended to cover PipelineReference, DatasetReference, etc. as well.

    Copy link

    openapi-pipeline-app bot commented Mar 25, 2024

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
      This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
      When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
      Automation should then add WaitForARMFeedback label.
      For details of the ARM review, see aka.ms/azsdk/pr-arm-review.
    • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @wuxu92
    Copy link

    wuxu92 commented May 9, 2024

    @Frey-Wang updated PipelineReference and DatasetReference. Should DataFlowReference ManagedVirtualNetworkReference and CredentialReference be updated as well? they have a custom x-ms-enum name for the type field.

    @wuxu92
    Copy link

    wuxu92 commented Jul 19, 2024

    @Frey-Wang could you take another look?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Factory DoNotMerge <valid label in PR review process> use to hold merge after approval resource-manager ShiftLeftViolation
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants