Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression caused by previous merge #2043

Merged
merged 22 commits into from
Nov 22, 2017
Merged

Fix regression caused by previous merge #2043

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cf77801
add can delegate flag to ra calls
darshanhs90 Sep 25, 2017
6c084f4
Merge branch 'current' of https://github.com/Azure/azure-rest-api-spe…
darshanhs90 Sep 25, 2017
7632bb3
update the version of api
darshanhs90 Nov 17, 2017
2996419
fix merge conflicts
darshanhs90 Nov 17, 2017
50cfc69
add dummy example files-to be updated in next commit
darshanhs90 Nov 18, 2017
b851045
update as per the comments
darshanhs90 Nov 18, 2017
6c3a206
update examples
darshanhs90 Nov 20, 2017
eb1a880
add new version support for go in readme
darshanhs90 Nov 20, 2017
b5cee27
fix json parse issue
darshanhs90 Nov 20, 2017
a3fdaa3
fix json parse issue
darshanhs90 Nov 20, 2017
d52d2dd
update x-ms-paths
darshanhs90 Nov 21, 2017
22db3d9
update x-ms-paths
darshanhs90 Nov 21, 2017
d93f686
update examples
darshanhs90 Nov 22, 2017
7deb908
update as per comments
darshanhs90 Nov 22, 2017
1beb095
udpated as per the comments
darshanhs90 Nov 22, 2017
e351d1d
fix readonly
darshanhs90 Nov 22, 2017
a051453
fix changed exmple files
darshanhs90 Nov 22, 2017
a8e3b75
Merge branch 'current' of https://github.com/Azure/azure-rest-api-spe…
darshanhs90 Nov 22, 2017
6ae868b
fix regression caused by previous merge
darshanhs90 Nov 22, 2017
6a66f7b
update example missed out
darshanhs90 Nov 22, 2017
9e2a412
update swagger
darshanhs90 Nov 22, 2017
8b8491d
fix model validation issues
darshanhs90 Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update swagger
  • Loading branch information
@darshanhs90
darshanhs90 committed Nov 22, 2017
commit 9e2a41207a27b29fdafebca79afa8c704817ed35
5 changes: 3 additions & 2 deletions ...horization/resource-manager/Microsoft.Authorization/2017-10-01-preview/authorization.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,8 @@
},
"type": {
"type": "string",
Copy link
Contributor

@mcardosos mcardosos Nov 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what we talked offline, this should be renamed to roleName

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there are two fields with name "type" in the response that is sent by the service.
we cant name this as rolename,because it wouldnt match the property "type" and would miss out having the value like custom role/builtin role

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name

In reply to: 152688623 [](ancestors = 152688623)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name

"description": "The role type."
"description": "The role type.",
"x-ms-client-name": "roleType"
},
"permissions": {
"type": "array",
Expand Down Expand Up @@ -718,7 +719,7 @@
"readOnly": true,
"description": "The role definition name."
},
"roletype": {
"type": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what we talked offline, this should stay as type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there are two fields with name "type" in the response that is sent by the service.
we cant name this as type,because we would leave out the property with value(for example) type which corresponds to "CUSTOM Role"

"readOnly": true,
"description": "The role definition type."
Expand Down