-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression caused by previous merge #2043
Changes from 1 commit
cf77801
6c084f4
7632bb3
2996419
50cfc69
b851045
6c3a206
eb1a880
b5cee27
a3fdaa3
d52d2dd
22db3d9
d93f686
7deb908
1beb095
e351d1d
a051453
a8e3b75
6ae868b
6a66f7b
9e2a412
8b8491d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -687,7 +687,8 @@ | |
}, | ||
"type": { | ||
"type": "string", | ||
"description": "The role type." | ||
"description": "The role type.", | ||
"x-ms-client-name": "roleType" | ||
}, | ||
"permissions": { | ||
"type": "array", | ||
|
@@ -718,7 +719,7 @@ | |
"readOnly": true, | ||
"description": "The role definition name." | ||
}, | ||
"roletype": { | ||
"type": { | ||
"type": "string", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From what we talked offline, this should stay as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since there are two fields with name "type" in the response that is sent by the service. |
||
"readOnly": true, | ||
"description": "The role definition type." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what we talked offline, this should be renamed to
roleName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are two fields with name "type" in the response that is sent by the service.
we cant name this as rolename,because it wouldnt match the property "type" and would miss out having the value like custom role/builtin role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name
In reply to: 152688623 [](ancestors = 152688623)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name