-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression caused by previous merge #2043
Conversation
@@ -718,7 +718,7 @@ | |||
"readOnly": true, | |||
"description": "The role definition name." | |||
}, | |||
"type": { | |||
"roletype": { | |||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what we talked offline, this should stay as type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are two fields with name "type" in the response that is sent by the service.
we cant name this as type,because we would leave out the property with value(for example) type which corresponds to "CUSTOM Role"
@@ -685,7 +685,7 @@ | |||
"type": "string", | |||
"description": "The role definition description." | |||
}, | |||
"roletype": { | |||
"type": { | |||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what we talked offline, this should be renamed to roleName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are two fields with name "type" in the response that is sent by the service.
we cant name this as rolename,because it wouldnt match the property "type" and would miss out having the value like custom role/builtin role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name
In reply to: 152688623 [](ancestors = 152688623)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok, there was some confusion on my side.
The property name should be the very same that is returned by the service. In this case, if you want to still get the benefits from x-ms-client-flatten, there is another extension that can be used to override the property name in the SDK code without changing serialization. Look into x-ms-client-name
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
No modification for AutorestCI/azure-sdk-for-node |
Related to #2031
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger