Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating version to 2021-06-01 for recoveryservicesbackup #14678

Merged
merged 21 commits into from
Jul 7, 2021
Merged

Updating version to 2021-06-01 for recoveryservicesbackup #14678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ad97335
Updating version to 2021-06-01 for msi support for iaasvm
monjain Jun 4, 2021
8f0ef99
adding example files
monjain Jun 16, 2021
d3700cc
resolving comments
monjain Jun 17, 2021
eb7ef6f
fixing validation issue
monjain Jun 17, 2021
7e6434d
undoing package-lock changes
monjain Jun 17, 2021
93a7281
fixing validation errors
monjain Jun 17, 2021
ee8a024
fixing non-identical model issue
monjain Jun 17, 2021
d6d2d6f
fixing lintdiff error
monjain Jun 17, 2021
aadf4ab
fixing lintdiff error
monjain Jun 17, 2021
2076869
append
monjain Jun 17, 2021
68d8e5c
Update readme.md
monjain Jun 22, 2021
44ea4d7
adding suppression
monikajainms Jun 22, 2021
7ad3050
Update readme.md
monikajainms Jun 25, 2021
7ebf060
Update readme.md
monikajainms Jun 25, 2021
0c81aeb
contract update
monikajainms Jun 29, 2021
aa58e2f
renaming managedidentityid
monikajainms Jun 29, 2021
1efea50
fixing prettier check
monikajainms Jun 29, 2021
8aca71a
resolving conflicts
monikajainms Jul 1, 2021
67f5868
reversing the exposure of identity url
monikajainms Jul 6, 2021
7abc499
Update bms.json
monikajainms Jul 6, 2021
f3893d3
Update bms.json
monikajainms Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...veryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3157,10 +3157,28 @@
"items": {
"type": "string"
}
},
"identityInfo": {
"$ref": "#/definitions/IdentityInfo",
"description": "Managed Identity information required to access customer storage account."
}
},
"x-ms-discriminator-value": "IaasVMRestoreRequest"
},
"IdentityInfo": {
"description": "Encapsulates Managed Identity related information",
"type": "object",
"properties": {
"isSystemAssignedIdentity": {
pilor marked this conversation as resolved.
Show resolved Hide resolved
"description": "To differentiate if the managed identity is system assigned or user assigned",
"type": "boolean"
},
"managedIdentityResourceId": {
"description": "Managed Identity Resource Id\r\nOptional: Might not be required in the case of system assigned managed identity",
"type": "string"
}
}
},
Copy link
Contributor

@j5lim j5lim Jun 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only change added in 2021-06-01 as well? Is there an example file show the usage of this? If not, can you please add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time please follow the ARM API Review Checklist that indicates how to make the very first commit for an efficient review (the second checkbox). Otherwise, it will be very hard to see what changed in the new api-version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 This is super important otherwise we'll need to review all the changes and will be adding comments to unmodified changes.

"InstantItemRecoveryTarget": {
"description": "Target details for file / folder restore.",
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion ...Microsoft.RecoveryServices/stable/2018-12-20/examples/AzureIaasVm/GetAccessToken_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"containerName": "IaasVMContainer;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
"protectedItemName": "VM;iaasvmcontainerv2;rshhtestmdvmrg;rshmdvmsmall",
"recoveryPointId": "26083826328862",
"api-version": "2018-12-20-preview",
"api-version": "2018-12-20",
"parameters": {
"properties": {
"tenantId": "33e01921-4d64-4f8c-a055-5bdaffd5e33d",
Expand Down
4 changes: 4 additions & 0 deletions ...coveryServices/stable/2018-12-20/examples/AzureIaasVm/TriggerCrossRegionRestore_Post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
"encryptionDetails": {
"encryptionEnabled": false
},
"identityInfo": {
"isSystemAssignedIdentity": false,
"managedIdentityResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/asmaskarRG1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/asmaskartestmsi"
},
"objectType": "IaasVMRestoreRequest",
"originalStorageAccountOption": false,
"recoveryPointId": "87178355392716",
Expand Down
Loading