Updating version to 2021-06-01 for recoveryservicesbackup #14678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @monikajainms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new optional property 'identityInfo' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2018-12-20/bms.json#L3070:7 Old: Microsoft.RecoveryServices/stable/2018-12-20/bms.json#L3070:7 |
️⚠️LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSystemAssignedIdentity Location: Microsoft.RecoveryServices/stable/2018-12-20/bms.json#L3172 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L66 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L111 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L156 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L317 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L374 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L51 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L96 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L141 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L194 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/recoveryservicesbackup/resource-manager/readme.md tag: specification/recoveryservicesbackup/resource-manager/readme.md#tag-package-2021-06 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 9 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/bms.json compared with base:stable/2021-04-01/bms.json
- current:stable/2021-06-01/bms.json compared with base:preview/2021-02-01-preview/bms.json
| Rule | Message |
|---|---|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L641:13 Old: Microsoft.RecoveryServices/stable/2021-04-01/bms.json#L641:13 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L4001:5 Old: Microsoft.RecoveryServices/stable/2021-04-01/bms.json#L3995:5 |
The following breaking changes are detected by comparison with latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies' removed or restructured? Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L3920:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies/{resourceGuardProxyName}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L3968:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies/{resourceGuardProxyName}/unlockDelete' removed or restructured? Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4117:5 |
|
| The new version is missing a definition that was found in the old version. Was 'UnlockDeleteRequest' removed or renamed? New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L3927:3 Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4178:3 |
|
| The new version has a different type 'object' than the previous one ''. New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L641:13 Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L641:13 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L4009:9 Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4239:9 |
|
| The new version is missing a property found in the old version. Was 'resourceGuardOperationRequests' renamed or removed? New: Microsoft.RecoveryServices/stable/2021-06-01/bms.json#L8311:7 Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L8506:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 18 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- recoveryservicesbackup/resource-manager/readme.md#package-2021-04
- recoveryservicesbackup/resource-manager/readme.md#package-2021-03
- recoveryservicesbackup/resource-manager/readme.md#package-2021-02-10
- recoveryservicesbackup/resource-manager/readme.md#package-2021-02-preview
- recoveryservicesbackup/resource-manager/readme.md#package-2021-02
- recoveryservicesbackup/resource-manager/readme.md#package-2021-01
- recoveryservicesbackup/resource-manager/readme.md#package-2020-12
- recoveryservicesbackup/resource-manager/readme.md#package-2020-10
- recoveryservicesbackup/resource-manager/readme.md#package-2020-07
- recoveryservicesbackup/resource-manager/readme.md#package-2020-02
- recoveryservicesbackup/resource-manager/readme.md#package-2019-06
- recoveryservicesbackup/resource-manager/readme.md#package-2019-05
- recoveryservicesbackup/resource-manager/readme.md#package-2017-07
- recoveryservicesbackup/resource-manager/readme.md#package-2016-06
- recoveryservicesbackup/resource-manager/readme.md#package-2016-08
- recoveryservicesbackup/resource-manager/readme.md#package-2016-12
- recoveryservicesbackup/resource-manager/readme.md#package-2017-07-only
- recoveryservicesbackup/resource-manager/readme.md#package-2021-06
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named IaasVMRestoreRequest -- properties.identityInfo: undefined => "$ref":"#/components/schemas/schemas:1421", "description":"Managed Identity information required to access customer storage account." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-03", "details":"Duplicate Schema named IaasVMRestoreRequest -- properties.identityInfo: undefined => "$ref":"#/components/schemas/schemas:1418", "description":"Managed Identity information required to access customer storage account." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-02-10", "details":"Duplicate Schema named IaasVMRestoreRequest -- properties.identityInfo: undefined => "$ref":"#/components/schemas/schemas:1417", "description":"Managed Identity information required to access customer storage account." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Duplicate Schema named IaasVMRestoreRequest -- properties.identityInfo: undefined => "$ref":"#/components/schemas/schemas:1438", "description":"Managed Identity information required to access customer storage account." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-02", "details":"Duplicate Schema named IaasVMRestoreRequest -- properties.identityInfo: undefined => "$ref":"#/components/schemas/schemas:1417", "description":"Managed Identity information required to access customer storage account." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named NewErrorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:1084" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named NewErrorResponse-error -- properties.details.$ref: undefined => "#/components/schemas/schemas:1088" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named AzureFileshareProtectedItem -- properties.healthStatus: undefined => "x-ms-enum":"name":"HealthStatus", "modelAsString":true, "$ref":"#/components/schemas/HealthStatus", "description":"backups running status for this backup item." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named AzureFileShareRecoveryPoint -- properties.recoveryPointType.$ref: undefined => "#/components/schemas/schemas:1112", properties.recoveryPointType.readOnly: undefined => true, properties.recoveryPointTime.$ref: undefined => "#/components/schemas/schemas:1113", properties.recoveryPointTime.readOnly: undefined => true, properties.fileShareSnapshotUri.$ref: undefined => "#/components/schemas/schemas:1114", properties.fileShareSnapshotUri.readOnly: undefined => true, properties.recoveryPointSizeInGB.$ref: undefined => "#/components/schemas/schemas:1115", properties.recoveryPointSizeInGB.readOnly: undefined => true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named AzureWorkloadPointInTimeRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1249" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named NewErrorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:1082" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named NewErrorResponse-error -- properties.details.$ref: undefined => "#/components/schemas/schemas:1086" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureFileshareProtectedItem -- properties.healthStatus: undefined => "x-ms-enum":"name":"HealthStatus", "modelAsString":true, "$ref":"#/components/schemas/HealthStatus", "description":"backups running status for this backup item." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureFileShareRecoveryPoint -- properties.recoveryPointType.$ref: undefined => "#/components/schemas/schemas:1110", properties.recoveryPointType.readOnly: undefined => true, properties.recoveryPointTime.$ref: undefined => "#/components/schemas/schemas:1111", properties.recoveryPointTime.readOnly: undefined => true, properties.fileShareSnapshotUri.$ref: undefined => "#/components/schemas/schemas:1112", properties.fileShareSnapshotUri.readOnly: undefined => true, properties.recoveryPointSizeInGB.$ref: undefined => "#/components/schemas/schemas:1113", properties.recoveryPointSizeInGB.readOnly: undefined => true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadPointInTimeRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1247" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadRecoveryPoint -- properties.recoveryPointTimeInUTC.$ref: undefined => "#/components/schemas/schemas:1248", properties.recoveryPointTimeInUTC.readOnly: undefined => true, properties.type.readOnly: undefined => true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadSAPHanaPointInTimeRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1243" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadSAPHanaRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1247" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadSQLPointInTimeRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1268" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"recoveryservicesbackup/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named AzureWorkloadSQLRecoveryPoint -- allOf.0.$ref: undefined => "#/components/schemas/schemas:1247", properties.extendedInfo.$ref: undefined => "#/components/schemas/schemas:1269" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
customer-reported
Swagger Generation Artifacts
|
|
Thank you for your contribution monikajainms! We will review the pull request and get back to you soon. |
|
|
|
NewApiVersionRequired reason: |
This was referenced Jun 4, 2021
|
Hi, @monikajainms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Jun 8, 2021
j5lim
reviewed
Jun 9, 2021
| "description": "Managed Identity URL\r\nOptional: Will be required only in CRR flow, and not in non-CRR flow", | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Is this only change added in 2021-06-01 as well? Is there an example file show the usage of this? If not, can you please add it?
There was a problem hiding this comment.
Next time please follow the ARM API Review Checklist that indicates how to make the very first commit for an efficient review (the second checkbox). Otherwise, it will be very hard to see what changed in the new api-version.
There was a problem hiding this comment.
+1 This is super important otherwise we'll need to review all the changes and will be adding comments to unmodified changes.
j5lim
added
ARMChangesRequested
TriggerCrossRegionRestore_Post.json example shows identityInfo returned in this object, but it is not modeled here. Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json:3069 in 8f0ef99. [](commit_id = 8f0ef99, deletion_comment = False) |
j5lim
reviewed
Jun 16, 2021
| "fabricName": "Azure", | ||
| "containerName": "IaasVMContainer;iaasvmcontainerv2;netsdktestrg;netvmtestv2vm1", | ||
| "protectedItemName": "VM;iaasvmcontainerv2;netsdktestrg;netvmtestv2vm1", | ||
| "api-version": "2021-01-01", |
leni-msft
reviewed
Jun 17, 2021
package-lock.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "@azure/avocado": { | |||
| "version": "0.7.2", | |||
| "resolved": "https://registry.npmjs.org/@azure/avocado/-/avocado-0.7.2.tgz", | |||
| "integrity": "sha512-9hKNfrwgbgDwSFxMxodYStIsCc2X5RujyazYx7hkh2N0wpwgvhRU1xKTK7P0qCY3I9/V2LVq3iwGWeHIfTUQoQ==", | |||
| "integrity": "sha1-dQH0CvR9JMOXcZw3JbkFfPnQl8s=", | |||
There was a problem hiding this comment.
please don't check in the package-lock.json file
filizt
reviewed
Jun 29, 2021
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json
Show resolved
Hide resolved
filizt
reviewed
Jun 29, 2021
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json
Outdated
Show resolved
Hide resolved
filizt
reviewed
Jun 29, 2021
...er/Microsoft.RecoveryServices/stable/2018-12-20/examples/AzureIaasVm/GetAccessToken_Get.json
Outdated
Show resolved
Hide resolved
monikajainms
changed the title
pilor
reviewed
Jun 29, 2021
...er/Microsoft.RecoveryServices/stable/2018-12-20/examples/AzureIaasVm/GetAccessToken_Get.json
Outdated
Show resolved
Hide resolved
jorgecotillo
added
ARMSignedOff
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 7, 2021
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Updating version to 2021-06-01 for msi support for iaasvm * adding example files * resolving comments * fixing validation issue * undoing package-lock changes * fixing validation errors * fixing non-identical model issue * fixing lintdiff error * fixing lintdiff error * append * Update readme.md * adding suppression * Update readme.md * Update readme.md * contract update * renaming managedidentityid * fixing prettier check * reversing the exposure of identity url * Update bms.json * Update bms.json Co-authored-by: monjain <35448521+monjain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.