Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api Management fixes for Additional Properties in s360 report #12891

Merged
merged 6 commits into from
Feb 21, 2021
Merged

Api Management fixes for Additional Properties in s360 report #12891

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
244b7d8
missing count property
solankisamir Feb 8, 2021
5bc8392
missing count property example
solankisamir Feb 8, 2021
0a9ca65
product description fix
solankisamir Feb 8, 2021
3811ad8
inner error
solankisamir Feb 8, 2021
84cdb94
updated dns changes
solankisamir Feb 8, 2021
71150fa
revert innererror change
solankisamir Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...nt/resource-manager/Microsoft.ApiManagement/preview/2020-06-01-preview/apimanagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@
"$ref": "#/definitions/ErrorFieldContract"
},
"description": "The list of invalid fields send in request, in case of validation error."
},
Copy link
Member

@allenjzhang allenjzhang Feb 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question. Typically details is an array of ErrorResponseBody (see common-type/resource-manager/v1/types.json). It come thru well in SDK such as for .NET as Exception.InnerExcpetions. Why intorudce another object as innerError like this? Should snap to the common error response.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, reverted this change. We will fix this in the service.

"innerError": {
"type": "object",
"description": "Inner Error."
}
},
"description": "Error Body contract."
Expand Down
2 changes: 1 addition & 1 deletion ...t/resource-manager/Microsoft.ApiManagement/preview/2020-06-01-preview/apimdeployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@
"ApiManagementService"
],
"operationId": "ApiManagementService_ApplyNetworkConfigurationUpdates",
"description": "Updates the Microsoft.ApiManagement resource running in the Virtual network to pick the updated network settings.",
"description": "Updates the Microsoft.ApiManagement resource running in the Virtual network to pick the updated DNS changes.",
"x-ms-examples": {
"ApiManagementApplyNetworkConfigurationUpdates": {
"$ref": "./examples/ApiManagementApplyNetworkConfigurationUpdates.json"
Expand Down
57 changes: 56 additions & 1 deletion ...ment/resource-manager/Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@
"description": "Page values.",
"readOnly": true
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any.",
Expand Down Expand Up @@ -1989,6 +1994,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -2141,6 +2151,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -2686,6 +2701,11 @@
"description": "Issue Attachment values.",
"readOnly": true
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any.",
Expand Down Expand Up @@ -2741,6 +2761,11 @@
"description": "Issue values.",
"readOnly": true
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any.",
Expand All @@ -2759,6 +2784,11 @@
"description": "Issue Comment values.",
"readOnly": true
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any.",
Expand Down Expand Up @@ -3135,6 +3165,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -3217,6 +3252,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -3958,7 +3998,7 @@
"description": {
"type": "string",
"description": "Product description. May include HTML formatting tags.",
"minLength": 1,
"minLength": 0,
"maxLength": 1000
},
"terms": {
Expand Down Expand Up @@ -4305,6 +4345,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -4364,6 +4409,11 @@
},
"description": "Page values."
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any."
Expand Down Expand Up @@ -5829,6 +5879,11 @@
"description": "Page values.",
"readOnly": true
},
"count": {
"type": "integer",
"format": "int64",
"description": "Total record count number across all pages."
},
"nextLink": {
"type": "string",
"description": "Next page link if any.",
Expand Down
3 changes: 2 additions & 1 deletion ...ft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListApiDiagnostics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
}
}
}
]
],
"count": 1
}
}
}
Expand Down
1 change: 1 addition & 0 deletions ...iManagement/preview/2020-06-01-preview/examples/ApiManagementListApiIssueAttachments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ....ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListApiIssueComments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...crosoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListApiIssues.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
3 changes: 2 additions & 1 deletion ...osoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListDiagnostics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@
}
}
}
]
],
"count": 1
}
}
}
Expand Down
1 change: 1 addition & 0 deletions ...osoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListGatewayApis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...icrosoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListGateways.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
}
}
],
"count": 2,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions .../Microsoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListIssues.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...ent/preview/2020-06-01-preview/examples/ApiManagementListNotificationRecipientEmails.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
}
}
],
"count": 3,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...ment/preview/2020-06-01-preview/examples/ApiManagementListNotificationRecipientUsers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...oft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListNotifications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
}
}
],
"count": 7,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...crosoft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListTemplates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down
1 change: 1 addition & 0 deletions ...soft.ApiManagement/preview/2020-06-01-preview/examples/ApiManagementListTenantAccess.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
}
}
],
"count": 1,
"nextLink": ""
}
}
Expand Down