Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Management fixes for Additional Properties in s360 report #12891

Merged
merged 6 commits into from
Feb 21, 2021

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Feb 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Fixes - https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#OBJECT_ADDITIONAL_PROPERTIES
https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#MIN_LENGTH

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ghost ghost added the API Management label Feb 8, 2021
@openapi-workflow-bot
Copy link

Hi, @solankisamir Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

    Rule Message
    1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
    New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3998:9
    Old: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3958:9
    1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
    New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3998:9
    Old: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3958:9
    1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
    New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3998:9
    Old: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3958:9
    1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
    New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3998:9
    Old: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3958:9
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 310 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ErrorFieldContract' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ErrorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'RegionContract' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'RegionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ResourceSkuResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ResourceSkuResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ResourceSkuCapacity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2020-06",
    "details":"The schema 'ResourceSku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fd0cd02. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    • ️✔️@azure/arm-apimanagement [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
      cmderr	[npmPack] created ./dist/arm-apimanagement.js in 1.6s
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from fd0cd02. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByApi' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityState' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    • Microsoft.Azure.Management.ApiManagement [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/ApiDiagnosticTests.cs(62,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantGitTests.cs(28,35): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/DiagnosticTests.cs(48,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(178,21): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(210,25): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(78,95): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(203,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(27,35): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(37,39): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(43,49): error CS1501: No overload for method 'RegeneratePrimaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(47,40): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(55,49): error CS1501: No overload for method 'RegenerateSecondaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(59,84): error CS1061: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecretsWithHttpMessagesAsync' and no accessible extension method 'ListSecretsWithHttpMessagesAsync' accepting a first argument of type 'ITenantAccessGitOperations' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(28,35): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(37,34): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(48,21): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Update' and the best extension method overload 'DelegationSettingsOperationsExtensions.Update(IDelegationSettingsOperations, string, string, PortalDelegationSettings, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(54,78): error CS7036: There is no argument given that corresponds to the required formal parameter 'accessName' of 'ITenantAccessOperations.GetWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(62,50): error CS1501: No overload for method 'RegeneratePrimaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(64,39): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(70,50): error CS1501: No overload for method 'RegenerateSecondaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(72,35): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(79,21): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Update' and the best extension method overload 'DelegationSettingsOperationsExtensions.Update(IDelegationSettingsOperations, string, string, PortalDelegationSettings, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/ApiDiagnosticTests.cs(62,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantGitTests.cs(28,35): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/DiagnosticTests.cs(48,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(178,21): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(210,25): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(78,95): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(203,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(27,35): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(37,39): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(43,49): error CS1501: No overload for method 'RegeneratePrimaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(47,40): error CS1929: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(55,49): error CS1501: No overload for method 'RegenerateSecondaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs(59,84): error CS1061: 'ITenantAccessGitOperations' does not contain a definition for 'ListSecretsWithHttpMessagesAsync' and no accessible extension method 'ListSecretsWithHttpMessagesAsync' accepting a first argument of type 'ITenantAccessGitOperations' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(28,35): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(37,34): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(48,21): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Update' and the best extension method overload 'DelegationSettingsOperationsExtensions.Update(IDelegationSettingsOperations, string, string, PortalDelegationSettings, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(54,78): error CS7036: There is no argument given that corresponds to the required formal parameter 'accessName' of 'ITenantAccessOperations.GetWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(62,50): error CS1501: No overload for method 'RegeneratePrimaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(64,39): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'ListSecrets' and the best extension method overload 'DelegationSettingsOperationsExtensions.ListSecrets(IDelegationSettingsOperations, string, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(70,50): error CS1501: No overload for method 'RegenerateSecondaryKey' takes 2 arguments [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(72,35): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Get' and the best extension method overload 'ApiManagementServiceOperationsExtensions.Get(IApiManagementServiceOperations, string, string)' requires a receiver of type 'IApiManagementServiceOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessTests.cs(79,21): error CS1929: 'ITenantAccessOperations' does not contain a definition for 'Update' and the best extension method overload 'DelegationSettingsOperationsExtensions.Update(IDelegationSettingsOperations, string, string, PortalDelegationSettings, string)' requires a receiver of type 'IDelegationSettingsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fd0cd02. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-apimanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model CertificateContract has a new parameter key_vault
      info	[Changelog]   - Model ApiManagementServiceUpdateParameters has a new parameter restore
      info	[Changelog]   - Model BackendCredentialsContract has a new parameter certificate_ids
      info	[Changelog]   - Model CacheUpdateParameters has a new parameter use_from_location
      info	[Changelog]   - Model AdditionalLocation has a new parameter zones
      info	[Changelog]   - Model NamedValueContract has a new parameter key_vault
      info	[Changelog]   - Model BackendServiceFabricClusterProperties has a new parameter client_certificate_id
      info	[Changelog]   - Model NamedValueUpdateParameters has a new parameter key_vault
      info	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter http2_enabled
      info	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter tls10_enabled
      info	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter tls11_enabled
      info	[Changelog]   - Model DiagnosticContract has a new parameter operation_name_format
      info	[Changelog]   - Model HostnameConfiguration has a new parameter identity_client_id
      info	[Changelog]   - Model NamedValueCreateContract has a new parameter key_vault
      info	[Changelog]   - Model PolicyCollection has a new parameter count
      info	[Changelog]   - Model RecipientUserCollection has a new parameter count
      info	[Changelog]   - Model ApiManagementServiceResource has a new parameter zones
      info	[Changelog]   - Model ApiManagementServiceResource has a new parameter restore
      info	[Changelog]   - Model HttpMessageDiagnostic has a new parameter data_masking
      info	[Changelog]   - Model RecipientEmailCollection has a new parameter count
      info	[Changelog]   - Model ApiManagementServiceBaseProperties has a new parameter restore
      info	[Changelog]   - Added operation NamedValueOperations.refresh_secret
      info	[Changelog]   - Added operation TenantAccessOperations.list_by_service
      info	[Changelog]   - Added operation TenantAccessOperations.create
      info	[Changelog]   - Added operation ApiManagementServiceOperations.get_domain_ownership_identifier
      info	[Changelog]   - Added operation UserSubscriptionOperations.get
      info	[Changelog]   - Added operation CertificateOperations.refresh_secret
      info	[Changelog]   - Added operation group ContentTypeOperations
      info	[Changelog]   - Added operation group TenantSettingsOperations
      info	[Changelog]   - Added operation group PortalSettingsOperations
      info	[Changelog]   - Added operation group ContentItemOperations
      info	[Changelog]   - Added operation group GatewayCertificateAuthorityOperations
      info	[Changelog]   - Added operation group DeletedServicesOperations
      info	[Changelog]   - Added operation group ApiManagementSkusOperations
      info	[Changelog]   - Added operation group PortalRevisionOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation CertificateOperations.create_or_update has a new signature
      info	[Changelog]   - Operation CertificateOperations.list_by_service has a new signature
      info	[Changelog]   - Operation EmailTemplateOperations.update has a new signature
      info	[Changelog]   - Operation GatewayHostnameConfigurationOperations.create_or_update has a new signature
      info	[Changelog]   - Operation GatewayHostnameConfigurationOperations.delete has a new signature
      info	[Changelog]   - Operation NamedValueOperations.list_by_service has a new signature
      info	[Changelog]   - Operation SubscriptionOperations.create_or_update has a new signature
      info	[Changelog]   - Operation SubscriptionOperations.update has a new signature
      info	[Changelog]   - Operation TenantAccessGitOperations.regenerate_primary_key has a new signature
      info	[Changelog]   - Operation TenantAccessGitOperations.regenerate_secondary_key has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.get has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.get_entity_tag has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.list_secrets has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.regenerate_primary_key has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.regenerate_secondary_key has a new signature
      info	[Changelog]   - Operation UserConfirmationPasswordOperations.send has a new signature
      info	[Changelog]   - Operation UserOperations.delete has a new signature
      info	[Changelog]   - Operation LoggerOperations.delete has a new signature
      info	[Changelog]   - Operation EmailTemplateOperations.update has a new signature
      info	[Changelog]   - Operation CertificateOperations.create_or_update has a new signature
      info	[Changelog]   - Operation GatewayApiOperations.list_by_service has a new signature
      info	[Changelog]   - Operation GatewayHostnameConfigurationOperations.list_by_service has a new signature
      info	[Changelog]   - Operation GatewayOperations.list_by_service has a new signature
      info	[Changelog]   - Operation TenantAccessOperations.update has a new signature
      info	[Changelog]   - Operation UserOperations.create_or_update has a new signature
      info	[Changelog]   - Model ConnectivityStatusContract has a new required parameter resource_type
      info	[Changelog]   - Model ConnectivityStatusContract has a new required parameter is_optional
      info	[Changelog]   - Model CacheContract has a new required parameter use_from_location
      info	[Changelog]   - Model CertificateCreateOrUpdateParameters has a new signature
      info	[Changelog]   - Model AccessInformationContract has a new signature
      info	[Changelog]   - Removed operation TenantAccessGitOperations.get
      info	[Changelog]   - Removed operation TenantAccessGitOperations.list_secrets
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from fd0cd02. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.4.9/node_modules/@octokit/request/dist-node/index.js:66:23
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (internal/process/task_queues.js:93:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:305:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:40:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:171:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:18:20
    • ️✔️apimanagement/mgmt/2019-12-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2019-01-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2018-01-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2017-03-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2016-10-10/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2016-07-07/apimanagement [View full logs
      info	[Changelog] No exported changes
      error	Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      error	The following packages are still pending:
      error		apimanagement/mgmt/2019-12-01/apimanagement
      error		apimanagement/mgmt/2019-01-01/apimanagement
      error		apimanagement/mgmt/2018-01-01/apimanagement
      error		apimanagement/mgmt/2017-03-01/apimanagement
      error		apimanagement/mgmt/2016-10-10/apimanagement
      error		apimanagement/mgmt/2016-07-07/apimanagement
      error		preview/apimanagement/mgmt/2019-12-01-preview/apimanagement
      error		preview/apimanagement/mgmt/2018-06-01-preview/apimanagement
    • ️✔️preview/apimanagement/mgmt/2019-12-01-preview/apimanagement
    • ️✔️preview/apimanagement/mgmt/2018-06-01-preview/apimanagement
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fd0cd02. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
    • ️✔️apimanagement [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

    @solankisamir
    Copy link
    Member Author

    @allenjzhang can you take a look at this?

    @@ -78,6 +78,10 @@
    "$ref": "#/definitions/ErrorFieldContract"
    },
    "description": "The list of invalid fields send in request, in case of validation error."
    },
    Copy link
    Member

    @allenjzhang allenjzhang Feb 10, 2021

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Question. Typically details is an array of ErrorResponseBody (see common-type/resource-manager/v1/types.json). It come thru well in SDK such as for .NET as Exception.InnerExcpetions. Why intorudce another object as innerError like this? Should snap to the common error response.

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks, reverted this change. We will fix this in the service.

    @solankisamir
    Copy link
    Member Author

    @allenjzhang addressed review comments. please take a look again. Thanks

    @solankisamir
    Copy link
    Member Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @allenjzhang
    Copy link
    Member

    /azp run CredScan

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @solankisamir
    Copy link
    Member Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @azure-pipelines
    Copy link

    Command 'reset' is not supported by Azure Pipelines.

    Supported commands
    • help:
      • Get descriptions, examples and documentation about supported commands
      • Example: help "command_name"
    • list:
      • List all pipelines for this repository using a comment.
      • Example: "list"
    • run:
      • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
      • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
    • where:
      • Report back the Azure DevOps orgs that are related to this repository and org
      • Example: "where"

    See additional documentation.

    @allenjzhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @solankisamir
    Copy link
    Member Author

    @allenjzhang the pipelines are still not running for some reason.

    @markcowl markcowl closed this Feb 17, 2021
    @markcowl markcowl reopened this Feb 17, 2021
    @markcowl
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @solankisamir
    Copy link
    Member Author

    @allenjzhang we have not published any SDK for this api-version.

    @solankisamir
    Copy link
    Member Author

    solankisamir commented Feb 18, 2021

    @allenjzhang can you please take a look. We need to get this in, to start working on the next api-version, which we are targeting for Build in April. Thanks'

    @solankisamir
    Copy link
    Member Author

    @allenjzhang if you can take a look at this PR also? Thanks

    @allenjzhang allenjzhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 21, 2021
    @allenjzhang allenjzhang merged commit fd0cd02 into Azure:master Feb 21, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …12891)
    
    * missing count property
    
    * missing count property example
    
    * product description fix
    
    * inner error
    
    * updated dns changes
    
    * revert innererror change
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    API Management Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants