Skip to content

Conversation

@JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Nov 3, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review November 3, 2025 08:09
Copilot AI review requested due to automatic review settings November 3, 2025 08:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR announces breaking changes for the Az.MySql module, specifically deprecating single server cmdlets that will be removed by May 2026. The changes update the module version to 1.5.0 and add breaking change attributes to affected cmdlets.

Key changes:

  • Addition of deprecation notices to the ChangeLog.md for single server cmdlets removal by May 2026
  • Application of breaking change attributes to single server cmdlets (deprecated by Az v16.0.0)
  • Application of preview messages to flexible server cmdlets announcing breaking changes in Az v16.0.0
  • Version bump from 1.4.0 to 1.5.0 and dependency update to Az.Accounts 5.3.0

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/MySql/MySql/ChangeLog.md Added deprecation announcement for single server cmdlets
src/MySql/MySql/Az.MySql.psd1 Updated module version dependencies and formatting
src/MySql/MySql.sln Updated project GUID references
src/MySql/MySql.Autorest/generate-info.json Updated generation ID
src/MySql/MySql.Autorest/docs/Az.MySql.md Updated module GUID
src/MySql/MySql.Autorest/custom/*.ps1 (multiple files) Added breaking change and preview message attributes to cmdlets
src/MySql/MySql.Autorest/README.md Added directive configuration for breaking change attributes
src/MySql/MySql.Autorest/Properties/AssemblyInfo.cs Updated assembly version to 1.5.0

subject: ^FlexibleServer
set:
preview-announcement:
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released in May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview message indicates 'Az v15.0.0' but all the cmdlet implementations use 'Az v16.0.0'. This inconsistency should be corrected to match the '16.0.0' version used throughout the PR in the actual cmdlet attributes.

Suggested change
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released in May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v16.0.0, to be released in May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"

Copilot uses AI. Check for mistakes.
Comment on lines +26 to +29
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in the PreviewMessage attribute. The multi-line string should have consistent indentation. Compare with Update-AzMySqlFlexibleServerConfiguration.ps1 lines 26-30 which use more consistent indentation with spaces after the opening quote on each line.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***********************************************************************************************")]

Copilot uses AI. Check for mistakes.
Comment on lines +28 to +31
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in the PreviewMessage attribute. The multi-line string should have consistent indentation. Some files (like Update-AzMySqlFlexibleServerConfiguration.ps1) use indentation with spaces after the opening quote, while this file doesn't.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]

Copilot uses AI. Check for mistakes.
@dolauli dolauli merged commit d07d809 into main Nov 4, 2025
17 of 18 checks passed
@dolauli dolauli self-assigned this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants