Skip to content

Conversation

@JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Nov 3, 2025

Description

Preannouncement PR:

  1. [PS] Mysql module migration autorest v4 breaking change announcement #28788
  2. [BC]MySQL Update Release Date to May 2026 #29120

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review November 3, 2025 04:38
Copilot AI review requested due to automatic review settings November 3, 2025 04:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes support for Azure Database for MySQL single-server cmdlets and focuses exclusively on Azure Database for MySQL flexible servers. This is a breaking change that removes approximately 20+ legacy cmdlets and introduces several improvements for flexible server management.

Key changes:

  • Removed all single-server cmdlets (e.g., Get-AzMySqlServer, New-AzMySqlServer, Update-AzMySqlConfiguration)
  • Retained and updated flexible server cmdlets
  • Updated module dependencies, output types, and parameter types
  • Added breaking change exception file with 102 documented breaking changes
  • Updated help documentation and tests

Reviewed Changes

Copilot reviewed 138 out of 217 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/MySql/MySql/ChangeLog.md Added breaking change notice with reference link
src/MySql/MySql/Az.MySql.psd1 Removed single-server cmdlets from exports; updated Az.Accounts dependency to 5.3.0
tools/StaticAnalysis/Exceptions/Az.MySql/BreakingChangeIssues.csv Added 102 breaking change exception entries documenting removed cmdlets and API changes
Multiple help files Removed documentation for single-server cmdlets; updated output types for flexible server cmdlets
Test files Removed tests for single-server cmdlets; updated flexible server test scenarios
src/MySql/MySql.Autorest/test/utils.ps1 Simplified test setup; improved password handling
Various .md files Updated parameter types from enums to strings; removed "To construct" notes for InputObject parameters

@@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249).
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry is too vague for users. It should explicitly state that single-server cmdlets have been removed and list the major breaking changes. Users need to understand what specific cmdlets are no longer available and what alternatives they should use. Consider adding bullet points listing the removed cmdlet categories (e.g., "Removed single-server cmdlets: Get-AzMySqlServer, New-AzMySqlServer, Update-AzMySqlConfiguration, etc.") and guidance to migrate to flexible server cmdlets.

Copilot generated this review using guidance from repository custom instructions.
@Pan-Qi Pan-Qi marked this pull request as draft January 8, 2026 06:19
@Pan-Qi Pan-Qi added Contains Breaking Change This PR contains breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@JunKai-v JunKai-v force-pushed the joyer/mysql-migrate-v4 branch from 8f1485f to 4770c2d Compare January 20, 2026 01:22
Copilot AI review requested due to automatic review settings January 20, 2026 01:33
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 138 out of 217 changed files in this pull request and generated 2 comments.

@@ -8,7 +8,7 @@ schema: 2.0.0
# New-AzMySqlFlexibleServerDatabase

## SYNOPSIS
Creates a new database or updates an existing database.
Create a new database or create an existing database.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYNOPSIS has a grammatical error. "Create a new database or create an existing database" should be "Create a new database or update an existing database" (or just "Creates a new database or updates an existing database").

Copilot uses AI. Check for mistakes.
@@ -27,7 +48,7 @@ New-AzMySqlFlexibleServerDatabase -InputObject <IMySqlIdentity> [-Charset <Strin
```

## DESCRIPTION
Creates a new database or updates an existing database.
Create a new database or create an existing database.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DESCRIPTION has the same grammatical error as the SYNOPSIS. "Create a new database or create an existing database" should be "Creates a new database or updates an existing database".

Copilot uses AI. Check for mistakes.
@JunKai-v JunKai-v marked this pull request as ready for review January 20, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants