[PS] Migrate ProviderHub module to autorest v4 #27864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Migrate the ProviderHub PowerShell module to Autorest v4 by updating documentation, scripts, and metadata to support new parameter-set patterns and simplified type/interface names.
- Introduced new parameter sets (
*ViaJsonFilePath,*ViaJsonString,*ViaIdentityProviderRegistrationExpanded) across docs and cmdlets - Replaced long-form
Api20201120.*type references with simplified interfaces (I*) - Updated README directives for Autorest v4 and refreshed AssemblyInfo metadata
Reviewed Changes
Copilot reviewed 102 out of 102 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ProviderHub/ProviderHub.Autorest/docs/*.md | Expanded syntax sections, added JSON/identity parameter sets, updated types |
| src/ProviderHub/ProviderHub.Autorest/custom/*.ps1 | Added new parameter-set attributes, deprecate DefaultProfile, update mapping logic |
| src/ProviderHub/ProviderHub.Autorest/README.md | Refined Autorest v4 directive variants |
| src/ProviderHub/ProviderHub.Autorest/Properties/AssemblyInfo.cs | Introduced assembly metadata and version info |
| src/ProviderHub/ProviderHub.Autorest/docs/Az.ProviderHub.md | Updated module GUID and cmdlet summaries |
Comments suppressed due to low confidence (2)
src/ProviderHub/ProviderHub.Autorest/custom/Remove-AzProviderHubSku.ps1:68
- The parameter set name 'DeleteViaIdentityResourcetypeRegistration' uses lowercase 't' in 'Resourcetype'. For consistency, rename it to 'DeleteViaIdentityResourceTypeRegistration'.
[Parameter(ParameterSetName='DeleteViaIdentityResourcetypeRegistration', Mandatory)]
src/ProviderHub/ProviderHub.Autorest/docs/Az.ProviderHub.md:5
- The Help Version (1.0.0.0) does not align with the AssemblyInfo version (0.3.1). Consider synchronizing these versions for consistency.
Help Version: 1.0.0.0
src/ProviderHub/ProviderHub.Autorest/docs/Invoke-AzProviderHubManifestCheckin.md
Show resolved
Hide resolved
isra-fel
requested review from
wyunchi-ms,
dolauli,
isra-fel,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh,
Pan-Qi,
msJinLei and
grizzlytheodore
as code owners
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
notyashhh
force-pushed
the
joyer/providerhub-migrate-v4
branch
from
d120f7b to
2329db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.