Skip to content

Add Code Owners to the Module Folders #27848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented May 27, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 02:35
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new code owners to ensure broader review coverage for key module folders.

  • Appends additional reviewers (@VeryEarly, @YanaXu, @vidai-msft, @NoriZC, @notyashhh, @Pan-Qi, @msJinLei) to Compute, PolicyInsights, Batch, and DeviceRegistry paths in the CODEOWNERS file.
Comments suppressed due to low confidence (1)

.github/CODEOWNERS:3

  • The owners list is split across two lines (note the trailing @). CODEOWNERS entries must list all users on a single line; merge the continuation line so the full list appears together.
/src/Compute/    @EdwinBernal1 @grizzlytheodore @ntangy @sandido @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @

Comment on lines 3 to 13
/src/Compute/ @EdwinBernal1 @grizzlytheodore @ntangy @sandido @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @
Pan-Qi @msJinLei
/src/PolicyInsights/ @pilor @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @
Pan-Qi @msJinLei
/src/Batch/ @wiboris @dpwatrous @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @
Pan-Qi @msJinLei

# Make sure Device Registry team gets notified of any DeviceRegistry PRs:
# PRLabel: %Device Registry
/src/DeviceRegistry/ @marcodalessandro @rohankhandelwal @riteshrao @davidemontanari @wyunchi-ms @dolauli @isra-fel
/src/DeviceRegistry/ @marcodalessandro @rohankhandelwal @riteshrao @davidemontanari @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @
Pan-Qi @msJinLei
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] These four module entries share the same owner list. Consider using a grouped path pattern (e.g., /src/{Compute,PolicyInsights,Batch,DeviceRegistry}/) to DRY up the file and simplify future updates.

Copilot uses AI. Check for mistakes.

@isra-fel isra-fel enabled auto-merge (squash) May 27, 2025 02:41
@isra-fel isra-fel merged commit eaff03a into Azure:main May 27, 2025
12 checks passed
isra-fel pushed a commit that referenced this pull request May 29, 2025
isra-fel pushed a commit that referenced this pull request May 29, 2025
@msJinLei msJinLei deleted the codeowner branch May 30, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants