-
Notifications
You must be signed in to change notification settings - Fork 4k
Add Code Owners to the Module Folders #27848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds new code owners to ensure broader review coverage for key module folders.
- Appends additional reviewers (
@VeryEarly
,@YanaXu
,@vidai-msft
,@NoriZC
,@notyashhh
,@Pan-Qi
,@msJinLei
) to Compute, PolicyInsights, Batch, and DeviceRegistry paths in the CODEOWNERS file.
Comments suppressed due to low confidence (1)
.github/CODEOWNERS:3
- The owners list is split across two lines (note the trailing
@
). CODEOWNERS entries must list all users on a single line; merge the continuation line so the full list appears together.
/src/Compute/ @EdwinBernal1 @grizzlytheodore @ntangy @sandido @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @
.github/CODEOWNERS
Outdated
/src/Compute/ @EdwinBernal1 @grizzlytheodore @ntangy @sandido @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @ | ||
Pan-Qi @msJinLei | ||
/src/PolicyInsights/ @pilor @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @ | ||
Pan-Qi @msJinLei | ||
/src/Batch/ @wiboris @dpwatrous @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @ | ||
Pan-Qi @msJinLei | ||
|
||
# Make sure Device Registry team gets notified of any DeviceRegistry PRs: | ||
# PRLabel: %Device Registry | ||
/src/DeviceRegistry/ @marcodalessandro @rohankhandelwal @riteshrao @davidemontanari @wyunchi-ms @dolauli @isra-fel | ||
/src/DeviceRegistry/ @marcodalessandro @rohankhandelwal @riteshrao @davidemontanari @wyunchi-ms @dolauli @isra-fel @VeryEarly @YanaXu @vidai-msft @NoriZC @notyashhh @ | ||
Pan-Qi @msJinLei |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] These four module entries share the same owner list. Consider using a grouped path pattern (e.g., /src/{Compute,PolicyInsights,Batch,DeviceRegistry}/
) to DRY up the file and simplify future updates.
Copilot uses AI. Check for mistakes.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.