Skip to content

Fix Az.TrustedSigning InvokeCiPolicySigning operation to use ShouldProcess #27456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025

Conversation

Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Mar 26, 2025

Description

This PR addresses #27441.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Jaxelr Jaxelr requested a review from janielMartell March 26, 2025 20:07
@Jaxelr
Copy link
Member Author

Jaxelr commented Mar 26, 2025

hey @janielMartell could you take a look at this PR prior to publishing?

@isra-fel isra-fel added this to the Az 13.5.0 (05/06/2025) milestone Mar 27, 2025
@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Jaxelr Jaxelr marked this pull request as ready for review April 2, 2025 02:44
@Jaxelr Jaxelr requested a review from notyashhh April 2, 2025 02:44
@dolauli
Copy link
Contributor

dolauli commented Apr 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli self-assigned this Apr 2, 2025
Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@notyashhh notyashhh merged commit e0d3f83 into Azure:main Apr 3, 2025
12 checks passed
@Jaxelr Jaxelr deleted the feature/fix-invokecipolicy branch April 3, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Az.TrustedSigning - InvokeCIPolicySigning - should implement ShouldProcess
4 participants