Fix Az.TrustedSigning InvokeCiPolicySigning operation to use ShouldProcess (#27456)

Author: Jaxelr

src/TrustedSigning/TrustedSigning.sln

@@ -18,7 +18,9 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Authenticators", "..\Accoun
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Authentication.ResourceManager", "..\Accounts\Authentication.ResourceManager\Authentication.ResourceManager.csproj", "{7A062235-C440-491C-AB28-1BEF6066B5C5}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.TrustedSigning", "TrustedSigning.Autorest\Az.TrustedSigning.csproj", "{DA76563A-9EDD-4C16-B145-3729C71CE139}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.TrustedSigning", "..\..\generated\TrustedSigning\TrustedSigning.Autorest\Az.TrustedSigning.csproj", "{DA76563A-9EDD-4C16-B145-3729C71CE139}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TestFx", "..\..\tools\TestFx\TestFx.csproj", "{86128D66-090F-3D0D-B081-F8F6D609F8F2}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -58,6 +60,10 @@ Global
 		{DA76563A-9EDD-4C16-B145-3729C71CE139}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{DA76563A-9EDD-4C16-B145-3729C71CE139}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{DA76563A-9EDD-4C16-B145-3729C71CE139}.Release|Any CPU.Build.0 = Release|Any CPU
+		{86128D66-090F-3D0D-B081-F8F6D609F8F2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{86128D66-090F-3D0D-B081-F8F6D609F8F2}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{86128D66-090F-3D0D-B081-F8F6D609F8F2}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{86128D66-090F-3D0D-B081-F8F6D609F8F2}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

src/TrustedSigning/TrustedSigning/ChangeLog.md

@@ -18,8 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Modified InvokeCiPolicySigning to include ShouldProcess command confirmation
 
 ## Version 0.1.0
 * Renamed from Az.CodeSigning
 * Adding support for control-plane commands via Az.TrustedSigning.Autorest
-    

src/TrustedSigning/TrustedSigning/Commands/InvokeCIPolicySigning.cs

@@ -22,7 +22,7 @@
 namespace Microsoft.Azure.Commands.TrustedSigning
 {
     [Alias("Invoke-" + ResourceManager.Common.AzureRMConstants.AzurePrefix + "CodeSigningCIPolicySigning")]
-    [Cmdlet(VerbsLifecycle.Invoke, ResourceManager.Common.AzureRMConstants.AzurePrefix + "TrustedSigningCIPolicySigning", DefaultParameterSetName = ByAccountProfileNameParameterSet)]
+    [Cmdlet(VerbsLifecycle.Invoke, ResourceManager.Common.AzureRMConstants.AzurePrefix + "TrustedSigningCIPolicySigning", DefaultParameterSetName = ByAccountProfileNameParameterSet, SupportsShouldProcess = true)]
     [OutputType(typeof(string))]
     public class InvokeCIPolicySigning : CodeSigningCmdletBase
     {
@@ -118,21 +118,23 @@ public class InvokeCIPolicySigning : CodeSigningCmdletBase
 
         public override void ExecuteCmdlet()
         {
-            ValidateFileType(ResolvePath(Path));
+            if (ShouldProcess(Destination, string.Format("Signing '{0}'", Path)))
+            {
+                ValidateFileType(ResolvePath(Path));
 
+                WriteMessage("CI Policy signing in progress....");
 
-            WriteMessage("CI Policy signing in progress....");
+                if (!string.IsNullOrEmpty(AccountName))
+                {
+                    CodeSigningServiceClient.SubmitCIPolicySigning(AccountName, ProfileName, EndpointUrl, ResolvePath(Path), ResolvePath(Destination), TimeStamperUrl);
+                }
+                else if (!string.IsNullOrEmpty(MetadataFilePath))
+                {
+                    CodeSigningServiceClient.SubmitCIPolicySigning(MetadataFilePath, ResolvePath(Path), ResolvePath(Destination), TimeStamperUrl);
+                }
 
-            if (!string.IsNullOrEmpty(AccountName))
-            {
-                CodeSigningServiceClient.SubmitCIPolicySigning(AccountName, ProfileName, EndpointUrl, ResolvePath(Path), ResolvePath(Destination), TimeStamperUrl);
-            }
-            else if (!string.IsNullOrEmpty(MetadataFilePath))
-            {
-                CodeSigningServiceClient.SubmitCIPolicySigning(MetadataFilePath, ResolvePath(Path), ResolvePath(Destination), TimeStamperUrl);
+                WriteMessage("CI Policy is successfully signed. " + ResolvePath(Destination));
             }
-
-            WriteMessage("CI Policy is successfully signed. " + ResolvePath(Destination));
         }
         private void WriteMessage(string message)
         {