Skip to content

breaking change message for New-AzVmss #20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2023
Merged

breaking change message for New-AzVmss #20935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
223787a
breaking change message
Feb 15, 2023
c5a0307
changelog
Feb 16, 2023
f343914
Merge branch 'main' into cplat/OrchestrationModeBreakingChange
BethanyZhou Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compute/Compute/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

-->
## Upcoming Release
* Added breaking change message for `New-AzVmss`.
* Added `-PerformancePlus` parameter to `New-AzDiskConfig`

## Version 5.4.0
Expand Down
4 changes: 3 additions & 1 deletion ...te/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetCreateOrUpdateMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@

namespace Microsoft.Azure.Commands.Compute.Automation
{
[GenericBreakingChange("Starting in May 2023 the \"New-AzVmss\" cmdlet will deploy with the Trusted Launch configuration by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" cmdlet will deploy with the Trusted Launch configuration by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch", "6.0.0")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" cmdlet will create a OrchestrationMode: Flexible VMSS by default unless explicitly provded \"-OrchestrationMode Uniform\".", "6.0.0")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" used with \"-OrchestrationMode Flexible\" will allow NAT pool to be configured. Before, VMSS in OrchestrationMode:Flexible defaulted NAT pool to be not configured(null).", "6.0.0")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the version I wrote: 6.0.0, be Az.Compute version or Az version?
I wrote 6.0.0 because with breaking change we will be increasing major version, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Please add change log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added @BethanyZhou

[Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Vmss", DefaultParameterSetName = "DefaultParameter", SupportsShouldProcess = true)]
[OutputType(typeof(PSVirtualMachineScaleSet))]
public partial class NewAzureRmVmss : ComputeAutomationBaseCmdlet
Expand Down