Skip to content

breaking change message for New-AzVmss #20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2023
Merged

breaking change message for New-AzVmss #20935

merged 3 commits into from
Feb 17, 2023

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Feb 15, 2023 •
edited
Loading

Description

adding breaking change messages for upcoming breaking changes in New-AzVmss

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

grizzlytheodore
grizzlytheodore commented Feb 15, 2023
View reviewed changes
...mpute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetCreateOrUpdateMethod.cs
[GenericBreakingChange("Starting in May 2023 the \"New-AzVmss\" cmdlet will deploy with the Trusted Launch configuration by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" cmdlet will deploy with the Trusted Launch configuration by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch", "6.0.0")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" cmdlet will create a OrchestrationMode: Flexible VMSS by default unless explicitly provded \"-OrchestrationMode Uniform\".", "6.0.0")]
[GenericBreakingChange("Starting May 2023, the \"New-AzVmss\" used with \"-OrchestrationMode Flexible\" will allow NAT pool to be configured. Before, VMSS in OrchestrationMode:Flexible defaulted NAT pool to be not configured(null).", "6.0.0")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the version I wrote: 6.0.0, be Az.Compute version or Az version?
I wrote 6.0.0 because with breaking change we will be increasing major version, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Please add change log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added @BethanyZhou

@grizzlytheodore
Copy link
Member Author

do i need to make changes to this file too? https://github.com/Azure/azure-powershell/blob/main/documentation/breaking-changes/upcoming-breaking-changes.md

@grizzlytheodore
Copy link
Member Author

@dcaro will you take a look at the breaking change messages?

@BethanyZhou
Copy link
Contributor

do i need to make changes to this file too? https://github.com/Azure/azure-powershell/blob/main/documentation/breaking-changes/upcoming-breaking-changes.md

No need to manually update this file. This file is generated.

@grizzlytheodore
Copy link
Member Author

@BethanyZhou added changelog

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit fcc0121 into main Feb 17, 2023
@wyunchi-ms wyunchi-ms deleted the cplat/OrchestrationModeBreakingChange branch January 10, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyZhou BethanyZhou BethanyZhou approved these changes

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@Sandido Sandido Awaiting requested review from Sandido

@haagha haagha Awaiting requested review from haagha

@dcaro dcaro Awaiting requested review from dcaro

Assignees

@BethanyZhou BethanyZhou

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grizzlytheodore @BethanyZhou