Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Set-AzExpressRouteGateway to allow either one of -MinScaleUnits and -MaxScaleUnits #14150

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Updated Set-AzExpressRouteGateway to allow either one of -MinScaleUnits and -MaxScaleUnits #14150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f96386
initial changes
nimaller Feb 7, 2021
4c4210e
suppress breaking change message
nimaller Feb 9, 2021
794f287
Update BreakingChangeIssues.csv
VeryEarly Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

## Upcoming Release
* Updated format list and format table views for Get-AzVirtualNetworkGatewayConnectionIkeSa
* Updated `set-azExpressRouteGateway` to allow parameter -MinScaleUnits without specifying -MaxScaleUnits

## Version 4.5.0
* Added new cmdlets for CRUD of VpnGatewayNATRule.
Expand Down
4 changes: 3 additions & 1 deletion src/Network/Network/Cortex/ExpressRouteGateway/SetAzureRmExpressRouteGatewayCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,13 @@ public class UpdateAzureRmExpressRouteGatewayCommand : ExpressRouteGatewayBaseCm
[Parameter(
Mandatory = false,
HelpMessage = "Min for the scale units for this ExpressRouteGateway.")]
[ValidateRange(1, 100)]
public uint MinScaleUnits { get; set; }

[Parameter(
Mandatory = false,
HelpMessage = "Max for the scale units for this ExpressRouteGateway.")]
[ValidateRange(1, 100)]
public uint MaxScaleUnits { get; set; }

[Parameter(
Expand Down Expand Up @@ -116,7 +118,7 @@ public override void Execute()
throw new PSArgumentException(Properties.Resources.ExpressRouteGatewayNotFound);
}

if (this.MinScaleUnits > 0 && this.MaxScaleUnits > 0)
if (this.MinScaleUnits > 0 || this.MaxScaleUnits > 0)
{
if (this.MinScaleUnits > this.MaxScaleUnits)
{
Expand Down
3 changes: 2 additions & 1 deletion tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzFirewallPolicyNatRuleCommand","New-AzFirewallPolicyNatRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzFirewallPolicyNatRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzFirewallPolicyNatRule'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzFirewallPolicyNatRuleCommand","New-AzFirewallPolicyNatRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzFirewallPolicyNatRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzFirewallPolicyNatRule'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.UpdateAzureRmExpressRouteGatewayCommand","Set-AzExpressRouteGateway","0","2150","A validate range has been added for parameter 'MinScaleUnits' for cmdlet 'Set-AzExpressRouteGateway'.","Remove the validate range from parameter 'MinScaleUnits'."