Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Set-AzExpressRouteGateway to allow either one of -MinScaleUnits and -MaxScaleUnits #14150

Merged

Conversation

nimaller
Copy link
Contributor

@nimaller nimaller commented Feb 7, 2021

Description

Currently, when using set-azexpressroutegateway, users can specify min scale units or max scale units, and the request will succeed but the values will be ignored. This PR fixes it by validating the range in min and max scale units, and allowing only one of them to be specified.

Copied from: #14145

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Contributor

@VeryEarly VeryEarly merged commit 1cc74ba into Azure:network-november Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants