Skip to content

Add sanitize duration in the debug message and removed in EndProcessing #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add sanitize duration in the debug message and removed in EndProcessing #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Common/AzurePSCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ private void WriteSecretsWarningMessage()
{
WriteWarning(string.Format(Resources.DisplaySecretsWarningMessage, MyInvocation.InvocationName, string.Join(", ", sanitizerInfo.DetectedProperties)));
}
WriteDebug($"Sanitizer took {sanitizerInfo.SanitizeDuration.TotalMilliseconds}ms to process the object of cmdlet {MyInvocation.InvocationName}.");
}
}
}
Expand Down
19 changes: 12 additions & 7 deletions src/Common/MetricHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,22 +690,27 @@ public override string ToString()
StringBuilder sb = new StringBuilder("AzureQoSEvent: ");
if (ShowTelemetry)
{
foreach(PropertyDescriptor descriptor in TypeDescriptor.GetProperties((this)))
{
string name = descriptor.Name;
object value = descriptor.GetValue(this);
sb.Append($"{name}: {value}; ");
}
foreach (PropertyDescriptor descriptor in TypeDescriptor.GetProperties((this)))
{
string name = descriptor.Name;
object value = descriptor.GetValue(this);
sb.Append($"{name}: {value}; ");
}
//InstallationId and InternalCalledCmdlets are properties of MetricHelper and not in qosEventObject.
sb.Append($"InternalCalledCmdlets: {Microsoft.WindowsAzure.Commands.Common.MetricHelper.InternalCalledCmdlets}; InstallaionId: {Microsoft.WindowsAzure.Commands.Common.MetricHelper.InstallationId}");
}
else
{
sb = sb.Append($" Module: {ModuleName}:{ModuleVersion}; CommandName: {CommandName}; PSVersion: {PSVersion}");
sb.Append($" Module: {ModuleName}:{ModuleVersion}; CommandName: {CommandName}; PSVersion: {PSVersion}");
}

sb.Append($"; IsSuccess: {IsSuccess}; Duration: {Duration}");

if (SanitizerInfo?.ShowSecretsWarning == true)
{
sb.Append($"; SanitizeDuration: {SanitizerInfo.SanitizeDuration}");
}

if (Exception != null)
{
sb.Append($"; Exception: {Exception.Message};");
Expand Down