Add sanitize duration in the debug message and removed in EndProcessing #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes in two files:
src/Common/AzurePSCmdlet.csandsrc/Common/MetricHelper.cs. The changes revolve around the handling and logging of sanitizer information. The debug log about the sanitizing process duration has been removed fromAzurePSCmdlet.cs. InMetricHelper.cs, theToString()method has been updated to include the sanitizing duration in the output string if theShowSecretsWarningproperty is set totrue.[
src/Common/AzurePSCmdlet.cs]: Removed the debug log line that displayed the time taken by the sanitizer to process the object of the cmdlet. This change simplifies the output and removes potentially unnecessary information.[
src/Common/MetricHelper.cs]: Updated theToString()method to include the sanitizing duration in the output string if theShowSecretsWarningproperty istrue. This change provides more detailed information about the sanitizing process when it's relevant.