Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: support AzureFirewall update operation for rule collections #1011

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Network: support AzureFirewall update operation for rule collections #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f65574b
Network: update interfaces for rule collection update operations
xseeseesee Mar 12, 2020
718e74c
Network: update interfaces
xseeseesee Mar 16, 2020
0a399a0
Network: update impl
xseeseesee Mar 16, 2020
80b028b
Network: update test and record session
xseeseesee Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 62 additions & 3 deletions Tests/Fluent.Tests/Network/AzureFirewallTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using Azure.Tests;
using Fluent.Tests.Common;
using Microsoft.Azure.Management.Network.Fluent;
using Microsoft.Azure.Management.Network.Fluent.Models;
using Microsoft.Azure.Management.ResourceManager.Fluent;
using Microsoft.Azure.Management.ResourceManager.Fluent.Core;
Expand Down Expand Up @@ -58,23 +59,81 @@ public void CanCreateUpdate()
.WithAlertModeForThreatIntel()
.Create();

//validate azure firewall
Assert.NotNull(azureFirewall);
Assert.Equal(AzureFirewallSkuName.AZFWVNet, azureFirewall.Sku.Name);
Assert.Equal(AzureFirewallThreatIntelMode.Alert, azureFirewall.ThreatIntelMode);
Assert.True(azureFirewall.AdditionalProperties.Count == 0);
//validate application rule collections
Assert.True(azureFirewall.ApplicationRuleCollections.Count == 1);
Assert.Equal(AzureFirewallRCActionType.Allow, azureFirewall.ApplicationRuleCollections[0].Action.Type);
Assert.True(azureFirewall.ApplicationRuleCollections[0].Rules.Count == 1);
Assert.True(azureFirewall.ApplicationRuleCollections[0].Priority == 200);
Assert.Equal("Allow-Google", azureFirewall.ApplicationRuleCollections[0].Rules[0].Name);
Assert.Equal(AzureFirewallSkuName.AZFWVNet, azureFirewall.Sku.Name);
Assert.Equal(AzureFirewallThreatIntelMode.Alert, azureFirewall.ThreatIntelMode);
Assert.True(azureFirewall.AdditionalProperties.Count == 0);
//validate network rule collections
Assert.True(azureFirewall.NetworkRuleCollections.Count == 1);
Assert.True(azureFirewall.NetworkRuleCollections[0].Rules.Count == 1);

azureFirewall.Update()
.WithDenyModeForThreatIntel()
.WithAdditionalProperty("key1", "valueToAdd")
.UpdateAzureFirewallNetworkRuleCollection("RCNet01")
.DefineAzureFirewallNetworkRule("Allow-SPEC")
.WithUdpProtocol()
.WithSourceAddress("10.0.1.0/24")
.WithDestinationAddress("209.244.0.5")
.WithDestinationAddress("209.244.0.6")
.WithDestinationPort("33")
.Attach()
.Attach()
.UpdateAzureFirewallApplicationRuleCollection("App-Coll01")
.UpdateAzureFirewallApplicationRule("Allow-Google")
.WithDescription("Updated v1")
.Attach()
.WithPriority(220)
.Attach()
.DefineAzureFirewallApplicationRuleCollection("App-Coll02")
.DefineAzureFirewallApplicationRule("Allow-LinkedIn")
.WithSourceAddress("10.0.1.0/24")
.WithHttpProtocol(1020)
.WithHttpsProtocol(1021)
.WithTargetFullQualifiedDomainName("www.linkedin.com")
.Attach()
.WithPriority(101)
.WithAllowActionType()
.Attach()
.Apply();

//validate azure firewall
Assert.Equal(AzureFirewallThreatIntelMode.Deny, azureFirewall.ThreatIntelMode);
Assert.True(azureFirewall.AdditionalProperties.Count == 1);
Assert.True(azureFirewall.AdditionalProperties.ContainsKey("key1"));
//validate application rule collections
Assert.True(azureFirewall.ApplicationRuleCollections.Count == 2);
IAzureFirewallApplicationRuleCollection collection1 = null;
IAzureFirewallApplicationRuleCollection collection2 = null;
foreach (var collection in azureFirewall.ApplicationRuleCollections)
{
if (string.Equals(collection.Name, "App-Coll01"))
{
collection1 = collection;
}
else if (string.Equals(collection.Name, "App-Coll02"))
{
collection2 = collection;
}
}
Assert.NotNull(collection1);
Assert.True(collection1.Priority == 220);
Assert.Equal("Updated v1", collection1.Rules[0].Description);

Assert.NotNull(collection2);
Assert.True(collection2.Rules.Count == 1);
Assert.Equal("Allow-LinkedIn", collection2.Rules[0].Name);
//validate network rule collections
Assert.True(azureFirewall.NetworkRuleCollections.Count == 1);
Assert.True(azureFirewall.NetworkRuleCollections[0].Rules.Count == 2);
Assert.Equal("Allow-DNS", azureFirewall.NetworkRuleCollections[0].Rules[0].Name);

}
finally
Expand Down
Loading