Network: support AzureFirewall update operation for rule collections #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
requested review from
ChenTanyi,
yaohaizh,
yungezz and
weidongxu-microsoft
yungezz
reviewed
Mar 16, 2020
| ipConfiguration = null; | ||
| } | ||
| return this; | ||
| return Attach(); |
There was a problem hiding this comment.
what's impact of remove existing appending rule action?
There was a problem hiding this comment.
I just move this appending action into define method. This is to align with update operations which don't required appending action.
|
HI @xccc-msft why this change is important in net fluent now? is same behavior in java fluent now? |
|
@yungezz this is requested by service team. On the other hand, the java(v1 & v2) lags behind for this support because Java doesn't support private DNS. Maybe, private DNS is a good service for you to ramp up |
weidongxu-microsoft
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.