Skip to content

Treat failure to load entry point as warning instead of error #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Treat failure to load entry point as warning instead of error #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f99a71
Treat failure to load entry point as warning instead of error
ejizba Sep 28, 2022
e8db8a0
warn/error based on function.json files
ejizba Sep 28, 2022
fd8dfe4
Revert "warn/error based on function.json files"
ejizba Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/startApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ async function loadEntryPointFile(functionAppDirectory: string, channel: WorkerC
}
} catch (err) {
const error = ensureErrorType(err);
error.isAzureFunctionsSystemError = true;
error.message = `Worker was unable to load entry point "${entryPointPattern}": ${error.message}`;
throw error;
channel.log({
message: `Worker was unable to load entry point "${entryPointPattern}": ${error.message}`,
level: LogLevel.Warning,
logCategory: LogCategory.System,
});
}
}
}
14 changes: 5 additions & 9 deletions test/eventHandlers/WorkerInitHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,12 +295,8 @@ describe('WorkerInitHandler', () => {
});

stream.addTestMessage(Msg.init(__dirname));
const errorMessage = `Worker was unable to load entry point "${fileName}": Found zero files matching the supplied pattern`;
await stream.assertCalledWith(
Msg.receivedInitLog,
Msg.error(errorMessage),
Msg.failedResponse(fileName, errorMessage)
);
const warningMessage = `Worker was unable to load entry point "${fileName}": Found zero files matching the supplied pattern`;
await stream.assertCalledWith(Msg.receivedInitLog, Msg.warning(warningMessage), Msg.response);
});

it('Fails for invalid entry point', async function (this: ITestCallbackContext) {
Expand All @@ -317,12 +313,12 @@ describe('WorkerInitHandler', () => {
});

stream.addTestMessage(Msg.init(__dirname));
const errorMessage = `Worker was unable to load entry point "${fileName}": test`;
const warningMessage = `Worker was unable to load entry point "${fileName}": test`;
await stream.assertCalledWith(
Msg.receivedInitLog,
Msg.loadingEntryPoint(fileName),
Msg.error(errorMessage),
Msg.failedResponse(fileName, errorMessage)
Msg.warning(warningMessage),
Msg.response
);
});
});