Treat failure to load entry point as warning instead of error #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
changed the title
AnatoliB
approved these changes
Sep 28, 2022
alrod
reviewed
Oct 3, 2022
This reverts commit e8db8a0.
|
Changing back so that all errors are treated as warnings for the entry point scenario. It's simpler and much less risky - discussed in further detail offline. |
hossam-nasr
approved these changes
Oct 3, 2022
ejizba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630
Most of the apps we saw with an error had "main" set to index.js but that file didn't exist. We don't don't want to break those existing users, so we will convert the error to a warning.
However, we still want to throw an error in the new programming model (which obviously doesn't have any existing users) - so we will use the existence of "function.json" files to determine which model is being used and act accordingly.EDIT: Changed our mind on this.